Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct English wording in error message #6890

Merged
merged 1 commit into from
Nov 22, 2021
Merged

fix: correct English wording in error message #6890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/skaffold/build/build_problems.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func suggestBuildPushAccessDeniedAction(cfg interface{}) []*proto.Suggestion {

return []*proto.Suggestion{{
SuggestionCode: proto.SuggestionCode_ADD_DEFAULT_REPO,
Action: "Trying running with `--default-repo` flag",
Action: "Try running with `--default-repo` flag",
}}
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/skaffold/build/build_problems_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ func TestBuildProblems(t *testing.T) {
{
description: "Push access denied when neither default repo or global config is defined",
err: fmt.Errorf("skaffold build failed: could not push image: denied: push access to resource"),
expected: "Build Failed. No push access to specified image repository. Trying running with `--default-repo` flag.",
expected: "Build Failed. No push access to specified image repository. Try running with `--default-repo` flag.",
expectedAE: &proto.ActionableErr{
ErrCode: proto.StatusCode_BUILD_PUSH_ACCESS_DENIED,
Message: "skaffold build failed: could not push image: denied: push access to resource",
Suggestions: []*proto.Suggestion{{
SuggestionCode: proto.SuggestionCode_ADD_DEFAULT_REPO,
Action: "Trying running with `--default-repo` flag",
Action: "Try running with `--default-repo` flag",
},
}},
},
Expand Down