Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cross compilation step of cloud build job #6956

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #6348

Description
This PR removes the cross target dependency from the release target, as well as the uploading to our gcs bucket. These things are now handled in our kokoro jobs and no longer need to be done here.

Follow-up Work (remove if N/A)
Move over the rest of our jobs to kokoro (release-lts, latest builds)

@MarlonGamez MarlonGamez requested a review from a team as a code owner December 9, 2021 21:16
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #6956 (3ac0760) into main (290280e) will decrease coverage by 1.66%.
The diff coverage is 56.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6956      +/-   ##
==========================================
- Coverage   70.48%   68.81%   -1.67%     
==========================================
  Files         515      551      +36     
  Lines       23150    25296    +2146     
==========================================
+ Hits        16317    17408    +1091     
- Misses       5776     6716     +940     
- Partials     1057     1172     +115     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b355c7...3ac0760. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 08895f4 into GoogleContainerTools:main Dec 9, 2021
@MarlonGamez MarlonGamez deleted the remove-cb-cross branch December 9, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants