feat(lsp): add validation checking to lsp #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
force-pushed
the
add-validation-logic-lsp-v2
branch
from
ec49e6b to
b746f0d
Compare
aaron-prindle
changed the title
aaron-prindle
force-pushed
the
add-validation-logic-lsp-v2
branch
2 times, most recently
from
8382042 to
98ec01c
Compare
|
Looks like some tests are failing. Can you please update the PR? |
aaron-prindle
force-pushed
the
add-validation-logic-lsp-v2
branch
from
98ec01c to
a1c761a
Compare
|
PR is updated, should be fixed now. Accidentally pushed a change to examples/profile-test which had a validation error (the change made to demonstrate how this works in the image posted) |
Codecov Report
@@ Coverage Diff @@
## main #7097 +/- ##
==========================================
- Coverage 70.48% 68.52% -1.97%
==========================================
Files 515 558 +43
Lines 23150 26148 +2998
==========================================
+ Hits 16317 17917 +1600
- Misses 5776 7002 +1226
- Partials 1057 1229 +172
Continue to review full report at Codecov.
|
|
I believe the kokoro test failure is a known flake - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up the
skaffold lspto the validation logic, allowing the LSP to mark (via Diagnostics) any skaffold.yaml validation errors that occur while iterating in an IDEExample showing this PR displaying the "Duplicate Image" validation rule in an IDE:
