Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skipping TestBuildKanikoInsecureRegistry pending investigation #7122

Closed
wants to merge 14 commits into from

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Feb 16, 2022

Related to #7121

I tried downgrading the kaniko version to older v1.6.0, however it did not work.

Skipping this test pending investigation.

@tejal29 tejal29 requested a review from a team as a code owner February 16, 2022 20:19
@tejal29 tejal29 requested a review from nkubala February 16, 2022 20:19
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #7122 (2ba1ba6) into main (290280e) will decrease coverage by 1.98%.
The diff coverage is 56.96%.

@@            Coverage Diff             @@
##             main    #7122      +/-   ##
==========================================
- Coverage   70.48%   68.49%   -1.99%     
==========================================
  Files         515      560      +45     
  Lines       23150    26506    +3356     
==========================================
+ Hits        16317    18155    +1838     
- Misses       5776     7096    +1320     
- Partials     1057     1255     +198     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 223 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tejal29 tejal29 changed the title chore: point kaniko image to gcr.io/kaniko-project/executor:v1.6.0 chore: Skipping TestBuildKanikoInsecureRegistry pending investigation Feb 16, 2022
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 17, 2022
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 17, 2022
@tejal29
Copy link
Contributor Author

tejal29 commented Feb 17, 2022

The kokoro job still timed out. I am thinking we need to increase the timeout.

@tejal29 tejal29 force-pushed the fix_kaniko_int_test branch from 32d36cd to 21b7d79 Compare February 17, 2022 22:58
@tejal29 tejal29 enabled auto-merge (squash) February 23, 2022 18:18
@tejal29
Copy link
Contributor Author

tejal29 commented Feb 23, 2022

increasing timeout to 90 mins.

@tejal29 tejal29 force-pushed the fix_kaniko_int_test branch from a3fb9e4 to 47655df Compare February 23, 2022 19:26
…ckly.

With run mode added to artifact hash, skaffold build images weren't used in the subsequent run/dev/test command. This led to building the same artifact twice
@tejal29 tejal29 force-pushed the fix_kaniko_int_test branch from 47655df to 33756cb Compare March 1, 2022 00:50
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 1, 2022
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 1, 2022
@MarlonGamez
Copy link
Contributor

MarlonGamez commented Mar 1, 2022

@tejal29 looks like the kokoro status was "canceled"? But seems like the tests are working properly. Not sure what happened so I'm gonna trigger a rerun

@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Mar 1, 2022
@tejal29 tejal29 disabled auto-merge March 1, 2022 22:57
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 1, 2022
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 2, 2022
@MarlonGamez
Copy link
Contributor

@tejal29 any idea as to why this might still be timing out ?

@MarlonGamez MarlonGamez force-pushed the fix_kaniko_int_test branch from 43878a1 to 77204e9 Compare March 10, 2022 20:39
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 10, 2022
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 23, 2022
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants