Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement cross-platform support for GCB build env #7134

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

gsquared94
Copy link
Contributor

Related: #6120

Description

This PR implements support for running cross-platform builds for GoogleCloudBuild build environment.

Testing instructions

  1. In this branch, go to directory integration/examples/cross-platform-builds
  2. Run:
    skaffold build --default-repo=gcr.io/k8s-skaffold --platform=linux/arm64 -p googleCloudBuild --cache-artifacts=false
    
    This will build the image for platform linux/arm64 on the GoogleCloudBuild build env.
  3. Verify the image was built for the right target, run:
    docker run --platform=linux/arm64 gcr.io/k8s-skaffold/skaffold-example:<tag>
    
    Should produce the output:
    Hello world! Running on linux/arm64
    Hello world! Running on linux/arm64
    ...
    

@gsquared94 gsquared94 requested a review from a team as a code owner February 21, 2022 22:10
@gsquared94 gsquared94 requested a review from tejal29 February 21, 2022 22:10
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #7134 (37fc75b) into main (290280e) will decrease coverage by 2.07%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7134      +/-   ##
==========================================
- Coverage   70.48%   68.40%   -2.08%     
==========================================
  Files         515      560      +45     
  Lines       23150    26239    +3089     
==========================================
+ Hits        16317    17950    +1633     
- Misses       5776     7055    +1279     
- Partials     1057     1234     +177     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de79cd...37fc75b. Read the comment docs.

@gsquared94 gsquared94 enabled auto-merge (squash) February 22, 2022 19:26
@gsquared94 gsquared94 disabled auto-merge February 22, 2022 19:45
@gsquared94 gsquared94 merged commit cd049e1 into GoogleContainerTools:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants