fix: add default value for status-check flag when no value is specified

[MarlonGamez]

Fixes problem addressed here: https://github.com/GoogleContainerTools/skaffold/pull/7089/files#r845391034

--status-check can now be used without specifying ={true|false}

[briandealwis]

Can we add a test for this?

[MarlonGamez]

@briandealwis Yes, do you think we should add a test for all NoOptDefValue flags?

[codecov]

Codecov Report

Merging #7278 (757d76c) into main (290280e) will decrease coverage by 1.97%.
The diff coverage is 56.96%.

@@            Coverage Diff             @@
##             main    #7278      +/-   ##
==========================================
- Coverage   70.48%   68.51%   -1.98%     
==========================================
  Files         515      560      +45     
  Lines       23150    26507    +3357     
==========================================
+ Hits        16317    18160    +1843     
- Misses       5776     7094    +1318     
- Partials     1057     1253     +196     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/deploy.go	52.00% <ø> (-1.85%)	⬇️
cmd/skaffold/app/cmd/dev.go	84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go	36.66% <0.00%> (-4.72%)	⬇️
cmd/skaffold/skaffold.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go	62.50% <14.28%> (-1.14%)	⬇️
cmd/skaffold/app/cmd/lsp.go	28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go	68.85% <40.00%> (-7.62%)	⬇️
cmd/skaffold/app/cmd/lint.go	42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go	48.88% <50.00%> (+0.24%)	⬆️
cmd/skaffold/app/skaffold.go	76.19% <70.00%> (-8.43%)	⬇️
... and 225 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[briandealwis]

This flag broke downstream consumers, so it seems worthy of some tests to ensure it doesn't happen again.

[MarlonGamez]

@briandealwis I included a test in this PR to ensure that skaffold runs with these flags passed in with no value 👍🏼

[byCedric]

Can we please leave this now as is, thanks for adding tests to make sure this doesn't break again. But now our pipeline broke twice:

1. For the previous change that broke --status-check with {true,false} change - PR fix: correctly set the default value of StatusCheck to nil #7089
2. For this change that broke --status-check true - https://github.com/expo/snack/runs/7411459432?check_suite_focus=true#step:9:11