[V1] refactor: rename helm.Deployer to helm.Deployer3 to prepare for helm31Deployer #7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
changed the title
Codecov Report
@@ Coverage Diff @@
## v1 #7415 +/- ##
=====================================
Coverage ? 68.48%
=====================================
Files ? 561
Lines ? 26542
Branches ? 0
=====================================
Hits ? 18178
Misses ? 7101
Partials ? 1263 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
renzodavid9
approved these changes
May 17, 2022
tejal29
added a commit
to tejal29/skaffold
that referenced
this pull request
Jun 24, 2022
…or helm.Deployer31 (GoogleContainerTools#7415)" This reverts commit 7d12109.
tejal29
added a commit
that referenced
this pull request
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting helm init on v1.
Relates to #6683
To add helm31 Deployer, we need to move this old deployer which manages deploying with helm 3.0, to a base and then re-use for helm30 Deployer and helm31 deployer.
The commands will be same. Only thing changing will be helm31 deployer will invoke
helm render