feat(ko): Google Cloud Build remote builds for the ko builder #7650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7650 +/- ##
==========================================
- Coverage 70.48% 66.64% -3.85%
==========================================
Files 515 585 +70
Lines 23150 28007 +4857
==========================================
+ Hits 16317 18664 +2347
- Misses 5776 7984 +2208
- Partials 1057 1359 +302
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Enables remote builds on Google Cloud Build when using the Skaffold `ko` builder. Since Skaffold embeds ko as a module, the Cloud Build step uses the `skaffold` binary to build and push the image. This means that we don't need to create and maintain a separate `ko` builder image. Tracking: GoogleContainerTools#7131 Related: GoogleContainerTools#7258
tejal29
approved these changes
Jul 15, 2022
|
|
||
| func skaffoldGCBEnv(env ...string) []string { | ||
| defaultEnv := []string{ | ||
| "SKAFFOLD_DETECT_MINIKUBE=false", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables remote builds on Google Cloud Build when using the Skaffold
kobuilder.Since Skaffold embeds ko as a module, the Cloud Build step uses the
skaffoldbinary to build and push the image. Since thegcr.io/k8s-skaffold/skaffoldimage contains the Go distribution, we can use this image on Cloud Build. This means that we don't need to create and maintain a separatekobuilder image for Cloud Build.Tracking: #7131
Related: #7258