-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove v1 runner interfaces and simplify code #7724
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Codecov Report
@@ Coverage Diff @@
## main #7724 +/- ##
==========================================
- Coverage 70.48% 66.62% -3.86%
==========================================
Files 515 590 +75
Lines 23150 28457 +5307
==========================================
+ Hits 16317 18960 +2643
- Misses 5776 8106 +2330
- Partials 1057 1391 +334
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
155ec5e
to
81a3c6f
Compare
dd2027c
to
8dfe9f4
Compare
a404fc3
to
1517520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Should merge after Beta release.
Simplifying skaffold codebase and moving all runner/v2 to runner.
Similarly moving all runcontext/v2 to runcontext. This will remove all dead v1 related code on main
Summary of changes