Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove v1 runner interfaces and simplify code #7724

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Aug 3, 2022

Should merge after Beta release.

Simplifying skaffold codebase and moving all runner/v2 to runner.
Similarly moving all runcontext/v2 to runcontext. This will remove all dead v1 related code on main

Summary of changes

git commit --amend
[rm_v1_runner b5c582c4b] remove v1 interfaces and simplify code
 Date: Tue Aug 2 18:05:09 2022 -0700
 49 files changed, 206 insertions(+), 235 deletions(-)
 rename pkg/skaffold/runner/{v2 => }/apply.go (99%)
 rename pkg/skaffold/runner/{v2 => }/cleanup.go (98%)
 rename pkg/skaffold/runner/{v2 => }/deploy.go (99%)
 rename pkg/skaffold/runner/{v2 => }/deploy_test.go (91%)
 rename pkg/skaffold/runner/{v2 => }/dev.go (99%)
 rename pkg/skaffold/runner/{v2 => }/dev_test.go (97%)
 rename pkg/skaffold/runner/{v2 => }/generate_pipeline.go (98%)
 rename pkg/skaffold/runner/{v2 => }/new.go (89%)
 rename pkg/skaffold/runner/{v2 => }/render.go (99%)
 rename pkg/skaffold/runner/runcontext/{v2 => }/context.go (99%)
 rename pkg/skaffold/runner/{v2 => }/runner_test.go (98%)
 rename pkg/skaffold/runner/{v2 => }/test.go (98%)
 delete mode 100644 pkg/skaffold/runner/v2/runner.go
 rename pkg/skaffold/runner/{v2 => }/verify.go (99%)

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 3, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tejal29 tejal29 requested a review from a team as a code owner August 3, 2022 01:16
@tejal29 tejal29 requested a review from MarlonGamez August 3, 2022 01:16
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #7724 (550dca1) into main (290280e) will decrease coverage by 3.85%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7724      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.86%     
==========================================
  Files         515      590      +75     
  Lines       23150    28457    +5307     
==========================================
+ Hits        16317    18960    +2643     
- Misses       5776     8106    +2330     
- Partials     1057     1391     +334     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 360 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tejal29 tejal29 force-pushed the rm_v1_runner branch 3 times, most recently from 155ec5e to 81a3c6f Compare August 12, 2022 19:44
@tejal29 tejal29 force-pushed the rm_v1_runner branch 3 times, most recently from dd2027c to 8dfe9f4 Compare August 16, 2022 17:06
@tejal29 tejal29 force-pushed the rm_v1_runner branch 2 times, most recently from a404fc3 to 1517520 Compare August 16, 2022 18:12
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tejal29 tejal29 merged commit 1cb39f9 into GoogleContainerTools:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants