Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add-render-event-in-runner #7781

Merged
merged 1 commit into from
Aug 18, 2022
Merged

chore: add-render-event-in-runner #7781

merged 1 commit into from
Aug 18, 2022

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Aug 16, 2022 •
edited
Loading

Fixes:#7755,#7275
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • add Render event task in Runner.Render method to keep it consistent with other stage.

Test Plan

  • run skaffold dev --rpc-port=8080 --event-log-file=logs.json in getting-started example then check contenct in logs.json.v2 file.
  • expect to see something like
{"timestamp":"2022-08-16T19:58:36.648627Z","taskEvent":{"id":"Render-1","task":"Render","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-16T19:58:36.648634Z","renderEvent":{"id":"0","taskId":"Render-1","status":"InProgress"}}
{"timestamp":"2022-08-16T19:58:36.649267Z","renderEvent":{"id":"0","taskId":"Render-1","status":"Succeeded"}}
{"timestamp":"2022-08-16T19:58:36.649273Z","taskEvent":{"id":"Render-1","task":"Render","iteration":1,"status":"Succeeded"}}

User facing changes (remove if N/A)

  • User should be able to see Render task event in dev flow from event logs.

Follow-up Work (remove if N/A)

  • document v2 event -> v1 event mapping.

@ericzzzzzzz ericzzzzzzz changed the title chore:add-render-event-in-runner chore: add-render-event-in-runner Aug 16, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #7781 (a2128de) into main (290280e) will decrease coverage by 3.85%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7781      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.86%     
==========================================
  Files         515      590      +75     
  Lines       23150    28461    +5311     
==========================================
+ Hits        16317    18963    +2646     
- Misses       5776     8107    +2331     
- Partials     1057     1391     +334
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 360 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz force-pushed the add-render-event-in-runner branch from cbafe7c to 8a2f294 Compare August 17, 2022 01:23
@ericzzzzzzz ericzzzzzzz requested a review from gsquared94 August 17, 2022 14:04
@tejal29
Copy link
Contributor

tejal29 commented Aug 17, 2022

Sorry, Please rebase!

@tejal29
Copy link
Contributor

tejal29 commented Aug 17, 2022

@ericzzzzzzz Can you run a sample dev session with a couple of rebuild, redeploy and re-render iterations and create a events file?

@ericzzzzzzz ericzzzzzzz force-pushed the add-render-event-in-runner branch from 8a2f294 to a2128de Compare August 18, 2022 14:32
@ericzzzzzzz
Copy link
Contributor Author

ericzzzzzzz commented Aug 18, 2022 •
edited
Loading 

{"timestamp":"2022-08-18T14:34:03.942327Z","metaEvent":{"entry":"Starting Skaffold: \u0026{Version:v1.38.0-208-g8a2f2948f ConfigVersion:skaffold/v3alpha1 GitVersion: GitCommit:8a2f2948f7db5bae7ec37813297841b55aa261c7 BuildDate:2022-08-16T15:57:10Z GoVersion:go1.18.1 Compiler:gc Platform:darwin/arm64 User:}","metadata":{"build":{"artifacts":[{"type":"DOCKER","name":"skaffold-example","context":".","dockerfile":"Dockerfile"}],"type":"LOCAL"},"deploy":{"deployers":[{"type":"KUBECTL","count":1}],"cluster":"MINIKUBE"},"runID":"87b9e4f7-7b59-4ad4-b9ab-a854cd9dbee8","render":{}}}}
{"timestamp":"2022-08-18T14:34:03.956213Z","taskEvent":{"id":"DevLoop-1","task":"DevLoop","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:03.956227Z","metaEvent":{"entry":"Starting Skaffold: \u0026{Version:v1.38.0-208-g8a2f2948f ConfigVersion:skaffold/v3alpha1 GitVersion: GitCommit:8a2f2948f7db5bae7ec37813297841b55aa261c7 BuildDate:2022-08-16T15:57:10Z GoVersion:go1.18.1 Compiler:gc Platform:darwin/arm64 User:}","metadata":{"build":{"artifacts":[{"type":"DOCKER","name":"skaffold-example","context":".","dockerfile":"Dockerfile"}],"type":"LOCAL"},"deploy":{"deployers":[{"type":"KUBECTL","count":1}],"cluster":"MINIKUBE"},"runID":"87b9e4f7-7b59-4ad4-b9ab-a854cd9dbee8","render":{}}}}
{"timestamp":"2022-08-18T14:34:03.956248Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mListing files to watch...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:03.956255Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34m - skaffold-example\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:04.930857Z","taskEvent":{"id":"Build-1","task":"Build","description":"Build containers","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:04.930878Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mGenerating tags...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:04.931251Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34m - skaffold-example -\u003e \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:04.967508Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"skaffold-example:v1.38.0-210-ga2128de94-dirty\n"}}
{"timestamp":"2022-08-18T14:34:04.967532Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mChecking cache...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:04.968475Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-1","artifact":"skaffold-example","step":"Cache","status":"InProgress","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:04.968495Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34m - skaffold-example: \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:04.968499Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-1","artifact":"skaffold-example","step":"Cache","status":"Failed","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:04.968502Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[33mNot found. Building\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:04.968512Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mStarting build...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:04.968520Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mFound [minikube] context, using local docker daemon.\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:04.969435Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-1","artifact":"skaffold-example","step":"Build","status":"InProgress","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:04.969444Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mBuilding [skaffold-example]...\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:04.969479Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mTarget platforms: [linux/arm64]\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:09.510838Z","skaffoldLogEvent":{"taskId":"Build-1","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mBuild [skaffold-example] succeeded\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:09.510856Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-1","artifact":"skaffold-example","step":"Build","status":"Succeeded","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:09.515610Z","taskEvent":{"id":"Build-1","task":"Build","iteration":1,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:09.515774Z","taskEvent":{"id":"Render-1","task":"Render","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:09.515929Z","renderEvent":{"id":"0","taskId":"Render-1","status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:09.516550Z","renderEvent":{"id":"0","taskId":"Render-1","status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:09.516558Z","taskEvent":{"id":"Render-1","task":"Render","iteration":1,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:09.516583Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mTags used in deployment:\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:09.516587Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34m - skaffold-example -\u003e \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:09.516589Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"skaffold-example:b3d08aaaa5d77cc83d8fcafd87e1611c75df7df0531e6e54a046fe441b82a5d7\n"}}
{"timestamp":"2022-08-18T14:34:09.516597Z","taskEvent":{"id":"Deploy-1","task":"Deploy","description":"Deploy to cluster","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:09.516604Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mStarting deploy...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:09.516609Z","deploySubtaskEvent":{"id":"0","taskId":"Deploy-1","status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:09.679284Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"0","level":"STANDARD","message":" - "}}
{"timestamp":"2022-08-18T14:34:09.679295Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"0","level":"STANDARD","message":"pod/getting-started created\n"}}
{"timestamp":"2022-08-18T14:34:09.680249Z","deploySubtaskEvent":{"id":"0","taskId":"Deploy-1","status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:09.680731Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mWaiting for deployments to stabilize...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:11.782871Z","statusCheckSubtaskEvent":{"id":"pod/getting-started","taskId":"Deploy-1","resource":"pod/getting-started","status":"Succeeded","message":"Succeeded","statusCode":"STATUSCHECK_SUCCESS"}}
{"timestamp":"2022-08-18T14:34:11.782888Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"pod/getting-started","level":"STANDARD","message":" - pod/getting-started: running.\n"}}
{"timestamp":"2022-08-18T14:34:11.782920Z","statusCheckSubtaskEvent":{"id":"pods","taskId":"Deploy-1","resource":"pods","status":"Succeeded","message":"Succeeded","statusCode":"STATUSCHECK_SUCCESS"}}
{"timestamp":"2022-08-18T14:34:11.782976Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"pods","level":"STANDARD","message":" - pods is ready.\n"}}
{"timestamp":"2022-08-18T14:34:11.783069Z","skaffoldLogEvent":{"taskId":"Deploy-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mDeployments stabilized in 2.102 seconds\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:11.783096Z","taskEvent":{"id":"Deploy-1","task":"Deploy","iteration":1,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:11.783108Z","taskEvent":{"id":"PortForward-1","task":"PortForward","description":"Port forward URLs","iteration":1,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:11.784050Z","taskEvent":{"id":"PortForward-1","task":"PortForward","iteration":1,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:11.789229Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[33mPress Ctrl+C to exit\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:11.789239Z","taskEvent":{"id":"DevLoop-1","task":"DevLoop","iteration":1,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:11.789958Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[33mWatching for changes...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:11.846257Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[91m[getting-started]\u001b[0m Hello world!\n"}}
{"timestamp":"2022-08-18T14:34:15.321639Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[91m[getting-started]\u001b[0m Hello world!\n"}}
{"timestamp":"2022-08-18T14:34:20.327055Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[91m[getting-started]\u001b[0m Hello world!\n"}}
{"timestamp":"2022-08-18T14:34:21.562923Z","taskEvent":{"id":"DevLoop-2","task":"DevLoop","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:21.562952Z","metaEvent":{"entry":"Starting Skaffold: \u0026{Version:v1.38.0-208-g8a2f2948f ConfigVersion:skaffold/v3alpha1 GitVersion: GitCommit:8a2f2948f7db5bae7ec37813297841b55aa261c7 BuildDate:2022-08-16T15:57:10Z GoVersion:go1.18.1 Compiler:gc Platform:darwin/arm64 User:}","metadata":{"build":{"artifacts":[{"type":"DOCKER","name":"skaffold-example","context":".","dockerfile":"Dockerfile"}],"type":"LOCAL"},"deploy":{"deployers":[{"type":"KUBECTL","count":1}],"cluster":"MINIKUBE"},"runID":"87b9e4f7-7b59-4ad4-b9ab-a854cd9dbee8","render":{}}}}
{"timestamp":"2022-08-18T14:34:21.565111Z","taskEvent":{"id":"Build-2","task":"Build","description":"Build containers","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:21.565150Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mGenerating tags...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:21.565163Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34m - skaffold-example -\u003e \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:21.619925Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"skaffold-example:v1.38.0-210-ga2128de94-dirty\n"}}
{"timestamp":"2022-08-18T14:34:21.619970Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mChecking cache...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:21.620445Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-2","artifact":"skaffold-example","step":"Cache","status":"InProgress","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:21.620458Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34m - skaffold-example: \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:21.620461Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-2","artifact":"skaffold-example","step":"Cache","status":"Failed","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:21.620465Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[33mNot found. Building\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:21.620530Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mStarting build...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:21.620553Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mFound [minikube] context, using local docker daemon.\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:21.620592Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-2","artifact":"skaffold-example","step":"Build","status":"InProgress","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:21.620600Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mBuilding [skaffold-example]...\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:21.620613Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mTarget platforms: [linux/arm64]\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:25.737484Z","skaffoldLogEvent":{"taskId":"Build-2","subtaskId":"skaffold-example","level":"STANDARD","message":"\u001b[34mBuild [skaffold-example] succeeded\n\u001b[0m"}}
{"timestamp":"2022-08-18T14:34:25.737512Z","buildSubtaskEvent":{"id":"skaffold-example","taskId":"Build-2","artifact":"skaffold-example","step":"Build","status":"Succeeded","hostPlatform":"darwin/arm64/v8","targetPlatforms":"linux/arm64"}}
{"timestamp":"2022-08-18T14:34:25.743726Z","taskEvent":{"id":"Build-2","task":"Build","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:25.743771Z","taskEvent":{"id":"Render-2","task":"Render","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:25.743778Z","renderEvent":{"id":"0","taskId":"Render-2","status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:25.744297Z","renderEvent":{"id":"0","taskId":"Render-2","status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:25.744303Z","taskEvent":{"id":"Render-2","task":"Render","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:25.744317Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mTags used in deployment:\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:25.744323Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34m - skaffold-example -\u003e \u001b[0m"}}
{"timestamp":"2022-08-18T14:34:25.744326Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"skaffold-example:19f37468822f0606d1cae5575dd8086848c96db10584d2bcfafde722ca3afe86\n"}}
{"timestamp":"2022-08-18T14:34:25.744333Z","taskEvent":{"id":"Deploy-2","task":"Deploy","description":"Deploy to cluster","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:25.744374Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mStarting deploy...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:25.744382Z","deploySubtaskEvent":{"id":"0","taskId":"Deploy-2","status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:25.902548Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"0","level":"STANDARD","message":" - "}}
{"timestamp":"2022-08-18T14:34:25.902578Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"0","level":"STANDARD","message":"pod/getting-started configured\n"}}
{"timestamp":"2022-08-18T14:34:25.904018Z","deploySubtaskEvent":{"id":"0","taskId":"Deploy-2","status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:25.904107Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mWaiting for deployments to stabilize...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:27.989982Z","statusCheckSubtaskEvent":{"id":"pod/getting-started","taskId":"Deploy-2","resource":"pod/getting-started","status":"Succeeded","message":"Succeeded","statusCode":"STATUSCHECK_SUCCESS"}}
{"timestamp":"2022-08-18T14:34:27.990002Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"pod/getting-started","level":"STANDARD","message":" - pod/getting-started: running.\n"}}
{"timestamp":"2022-08-18T14:34:27.990038Z","statusCheckSubtaskEvent":{"id":"pods","taskId":"Deploy-2","resource":"pods","status":"Succeeded","message":"Succeeded","statusCode":"STATUSCHECK_SUCCESS"}}
{"timestamp":"2022-08-18T14:34:27.990102Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"pods","level":"STANDARD","message":" - pods is ready.\n"}}
{"timestamp":"2022-08-18T14:34:27.990206Z","skaffoldLogEvent":{"taskId":"Deploy-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mDeployments stabilized in 2.086 seconds\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:27.990250Z","taskEvent":{"id":"Deploy-2","task":"Deploy","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:27.990270Z","taskEvent":{"id":"PortForward-2","task":"PortForward","description":"Port forward URLs","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:27.990276Z","taskEvent":{"id":"PortForward-2","task":"PortForward","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:27.990281Z","taskEvent":{"id":"DevLoop-2","task":"DevLoop","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:27.990298Z","skaffoldLogEvent":{"taskId":"DevLoop-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[33mWatching for changes...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:31.036007Z","skaffoldLogEvent":{"taskId":"DevLoop-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[91m[getting-started]\u001b[0m Hello world0!\n"}}
{"timestamp":"2022-08-18T14:34:33.337943Z","taskEvent":{"id":"Render-2","task":"Render","iteration":2,"status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:33.337950Z","renderEvent":{"id":"0","taskId":"Render-2","status":"InProgress"}}
{"timestamp":"2022-08-18T14:34:33.339670Z","renderEvent":{"id":"0","taskId":"Render-2","status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:33.339676Z","taskEvent":{"id":"Render-2","task":"Render","iteration":2,"status":"Succeeded"}}
{"timestamp":"2022-08-18T14:34:33.339689Z","skaffoldLogEvent":{"taskId":"DevLoop-2","subtaskId":"-1","level":"STANDARD","message":"\u001b[34mCleaning up...\u001b[0m\n"}}
{"timestamp":"2022-08-18T14:34:33.389613Z","skaffoldLogEvent":{"taskId":"DevLoop-2","subtaskId":"-1","level":"STANDARD","message":" - "}}
{"timestamp":"2022-08-18T14:34:33.389644Z","skaffoldLogEvent":{"taskId":"DevLoop-2","subtaskId":"-1","level":"STANDARD","message":"pod \"getting-started\" deleted\n"}}

tested rebuild, re-render, redeploy,
Note: we see one more Render event than dev iteration time, as we call r.render for cleanup after runDev finishes.

@tejal29 tejal29 merged commit 8c342ee into GoogleContainerTools:main Aug 18, 2022
@ericzzzzzzz ericzzzzzzz mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@gsquared94 gsquared94 Awaiting requested review from gsquared94

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericzzzzzzz @tejal29