Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add auth to image pull #7814

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Aug 25, 2022

Fixes: #7812

@tejal29
Copy link
Contributor

tejal29 commented Aug 25, 2022

Verified, this is working in my bug bash

@gsquared94 gsquared94 enabled auto-merge (squash) August 25, 2022 20:42
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #7814 (2e9a59d) into main (290280e) will decrease coverage by 3.99%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7814      +/-   ##
==========================================
- Coverage   70.48%   66.49%   -4.00%     
==========================================
  Files         515      593      +78     
  Lines       23150    28650    +5500     
==========================================
+ Hits        16317    19050    +2733     
- Misses       5776     8188    +2412     
- Partials     1057     1412     +355     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 364 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 merged commit da270ed into GoogleContainerTools:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold build --platform=linux/arm64,linux/amd64 gives unauthorized error in certain cases
3 participants