Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the flag from deploy command #7823

Conversation

renzodavid9
Copy link
Contributor

Fixes: #7819
Merge before/after: Dependent or prerequisite PRs

Description
Remove the --platform flag from the deploy command due to it doesn't influence the final result and could be confusing to have the flag available.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #7823 (c5f17f5) into main (290280e) will decrease coverage by 3.83%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7823      +/-   ##
==========================================
- Coverage   70.48%   66.65%   -3.84%     
==========================================
  Files         515      593      +78     
  Lines       23150    28682    +5532     
==========================================
+ Hits        16317    19117    +2800     
- Misses       5776     8162    +2386     
- Partials     1057     1403     +346     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 366 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Aug 30, 2022

This is PR is failing currently as the PR commit title doesn't conform to conventionalcommits
Change the commit title to be:
fix: Remove the flag from deploy command

from
Remove the flag from deploy command

and all tests should pass

@aaron-prindle aaron-prindle marked this pull request as ready for review August 30, 2022 19:17
@renzodavid9 renzodavid9 changed the title Remove the flag from deploy command fix: Remove the flag from deploy command Aug 30, 2022
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle merged commit 4a11ec1 into GoogleContainerTools:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants