Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix incorrect default set for project for jib #7857

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 12, 2022

Fixes #7454

I verified for jib project key there was no default set in pkg/skaffold/schema/defaults folder and also nothing checked here.

func getProjectKey(workspace string, a *latest.JibArtifact) projectKey {

@tejal29 tejal29 requested a review from a team as a code owner September 12, 2022 18:36
@tejal29 tejal29 changed the title Fix incorrect default set for project for jib docs: Fix incorrect default set for project for jib Sep 12, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #7857 (c0ddd8d) into main (290280e) will decrease coverage by 3.83%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7857      +/-   ##
==========================================
- Coverage   70.48%   66.65%   -3.84%     
==========================================
  Files         515      593      +78     
  Lines       23150    28726    +5576     
==========================================
+ Hits        16317    19146    +2829     
- Misses       5776     8174    +2398     
- Partials     1057     1406     +349     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tejal29 tejal29 merged commit 1c6fdd1 into main Sep 14, 2022
@tejal29 tejal29 deleted the tejal29-patch-1 branch September 14, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jib sub-project name is not inferred from directory name
1 participant