Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport Bazel build context fixes to v1 #7866

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix: backport Bazel build context fixes to v1 #7866

merged 2 commits into from
Sep 21, 2022

Conversation

mikekamornikov
Copy link
Contributor

@mikekamornikov mikekamornikov commented Sep 18, 2022 •
edited
Loading

Fixes: #7864

Description
I've backported commits which fix the usage of Bazel artifact context. Now it's possible to put skaffold.yaml file to subfolder of bazel workspace and set context to a relative path.

Before:

skaffold-v1.39.2 version
v1.39.2

skaffold-v1.39.2 run -p k8s-usw2-dev-skaffold
WARN[0000] failed to detect active kubernetes cluster node platform. Specify the correct build platform in the `skaffold.yaml` file or using the `--platform` flag  subtask=-1 task=DevLoop
Generating tags...
 ...
(18:34:17) INFO: Build completed successfully, 1 total action
build [***] failed: reading image "bazel-out/darwin_arm64-dbg-ST-4a519fd6d3e4/bin/***r/docker.tar": open bazel-out/darwin_arm64-dbg-ST-4a519fd6d3e4/bin/***/docker.tar: no such file or directory

skaffold-v1.39.2-patched version
v1.39.2-2-gc8d606d52

skaffold-v1.39.2-patched run -p k8s-usw2-dev-skaffold
WARN[0000] failed to detect active kubernetes cluster node platform. Specify the correct build platform in the `skaffold.yaml` file or using the `--platform` flag  subtask=-1 task=DevLoop
Generating tags...
...
(18:34:45) INFO: Build completed successfully, 1 total action
Build [***] succeeded
Starting test...
Tags used in deployment:
...
Deployments stabilized in 3.686 seconds
You can also run [skaffold run --tail] to get the logs

morozov and others added 2 commits September 18, 2022 17:54
@morozov @mikekamornikov
fix: running skaffold from a directory other than repository root (Go…
1609cd8 
…ogleContainerTools#7430)
@reltuk @tejal29 @mikekamornikov
use absolute paths to the container_image.tar in bazel build. (Google…
c8d606d 
…ContainerTools#7671)

* fix: use absolute paths to the container_image.tar in bazel build.

* fix unit tests

Co-authored-by: tejal29 <tejal29@gmail.com>
@mikekamornikov mikekamornikov requested a review from a team as a code owner September 18, 2022 16:50
@mikekamornikov mikekamornikov requested review from renzodavid9 and removed request for a team September 18, 2022 16:50
@mikekamornikov mikekamornikov changed the title Backport Bazel build context fixes to v1 fix: backport Bazel build context fixes to v1 Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v1@7ed1d72). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             v1    #7866   +/-   ##
=====================================
  Coverage      ?   68.38%           
=====================================
  Files         ?      563           
  Lines         ?    26692           
  Branches      ?        0           
=====================================
  Hits          ?    18252           
  Misses        ?     7173           
  Partials      ?     1267

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Sep 19, 2022 •
edited
Loading

Thanks for the PR @mikekamornikov! Currently I am restarting the Windows Integration Test job as there was a test error (but this is test error likely a flake unrelated to your changes). Once I can verify this is a flake and we have all tests passing we can merge this.

gsquared94
gsquared94 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@gsquared94 gsquared94 merged commit 894fb67 into GoogleContainerTools:v1 Sep 21, 2022
@mikekamornikov mikekamornikov deleted the issue-7864 branch September 21, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsquared94 gsquared94 gsquared94 approved these changes

@renzodavid9 renzodavid9 Awaiting requested review from renzodavid9 renzodavid9 is a code owner automatically assigned from GoogleContainerTools/skaffold-team

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikekamornikov @aaron-prindle @gsquared94 @morozov @reltuk