Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for helm chart with multiple images #7874

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

filipenf
Copy link
Contributor

Shows how to override multiple images in a helm template

Description
Documentation-only changes: Add a snippet showing how to override multiple images from skaffold-built artifacts. I was testing with this and thought an example in the doc would be useful. Thoughts?

@google-cla
Copy link

google-cla bot commented Sep 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Sep 21, 2022

Thanks for the submission @filipenf! Currently you have updated:
docs/content/en/docs/pipeline-stages/deployers/helm.md

We have recently forked our docs into a docs and a docs-v2 folder. Can you also update the
docs-v2/content/en/docs/pipeline-stages/deployers/helm.md
file with this change as well?

Additionally our repo has a unit test to enforce Conventional Commits. Can you ammend your commit message to add a prefix - docs: eg:
docs: Add an example for helm chart with multiple images

Once these are resolved we can merge!

@filipenf
Copy link
Contributor Author

@aaron-prindle thanks for the info, I just checked the helm.md in the v2 path you mentioned and I noticed that it is missing a few of the sections from the original file. Would you also like me to match those or should I just add the new bits?

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Sep 22, 2022

@filipenf just the new bits thanks! I believe the other differences are inherent to Skaffold v1 vs v2 (so they should be different)

@filipenf
Copy link
Contributor Author

@aaron-prindle I added just the new bits and updated the commit message, however I noticed that the whole ## Image Configuration section is missing in the v2 doc. Is that expected?

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Sep 22, 2022

@filipenf ah, I see now. Yes, if you wouldn't mind adding that section as well here that would be great. Thanks for the extra analysis here!

Example showing how to override multiple images from a helm template
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@aaron-prindle aaron-prindle enabled auto-merge (squash) September 22, 2022 19:56
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #7874 (aabee23) into main (290280e) will decrease coverage by 3.80%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7874      +/-   ##
==========================================
- Coverage   70.48%   66.67%   -3.81%     
==========================================
  Files         515      593      +78     
  Lines       23150    28698    +5548     
==========================================
+ Hits        16317    19135    +2818     
- Misses       5776     8157    +2381     
- Partials     1057     1406     +349     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 366 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit b45769a into GoogleContainerTools:main Sep 22, 2022
@filipenf filipenf deleted the patch-1 branch September 22, 2022 21:14
@iosifnicolae2
Copy link

When using schema v3 artifactOverrides does not exist, instead I've used setValueTemplates as follow:

manifests:
  helm:
    releases:
    - setValueTemplates:
        firstContainerImage.repo: '{{.IMAGE_REPO}}'
        firstContainerImage.tag: '{{.IMAGE_TAG}}'
        secondContainerImage.repo: '{{.IMAGE_REPO2}}'
        secondContainerImage.tag: '{{.IMAGE_TAG2}}'
        ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants