Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable platform flag in render command #7885

Merged

Conversation

ericzzzzzzz
Copy link
Contributor

Description

  • a user can use --digest-source=local with render command followed by skaffold apply command to deploy his applications. In this flow, skaffold will build image to get digest first, by default the arch of built image by docker is the same as the host, if the host is connected to a cluster which doesn't have compatible nodes can run the image, say the host is an amd machine and it's connected to arm cluster, the deployment will fail.
  • enable platform in render to allow user specify the target platform a build artifact is for.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #7885 (6f7e9af) into main (290280e) will decrease coverage by 3.80%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7885      +/-   ##
==========================================
- Coverage   70.48%   66.67%   -3.81%     
==========================================
  Files         515      593      +78     
  Lines       23150    28698    +5548     
==========================================
+ Hits        16317    19135    +2818     
- Misses       5776     8155    +2379     
- Partials     1057     1408     +351     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz merged commit 2a2706e into GoogleContainerTools:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants