-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for deploying Cloud Run Jobs. #7915
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7915 +/- ##
==========================================
- Coverage 70.48% 66.68% -3.81%
==========================================
Files 515 596 +81
Lines 23150 29010 +5860
==========================================
+ Hits 16317 19344 +3027
- Misses 5776 8235 +2459
- Partials 1057 1431 +374
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@bskaplan we could potentially merge this before 2.0.0 release next week. Would that be good? Is there any follow up work for this feature completion e.g. feature work, metrics, tests ? If yes, lets wait before we merge this in. |
There's no hurry to merge this. I still plan on adding an integration test after this PR. |
Sorry for the delay here, looking at this now. In testing with the following yaml I was not able to deploy a
skaffold logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps we can discuss a bit more the vision for Job
vs Execution
support in the integration test PR as I am still a bit confused how a user can execute a job from skaffold atm
Yeah, I couldn't figure out a way to map Executions to Skaffold's existing functionality. I figured it was still worth it to have support in Skaffold in case you wanted to have a Job managed by a Service (where the Service would trigger the executions to do asynchronous work). |
Ah this makes sense to me now. Thanks! |
Related: #7914
Description
Add initial support for deploying Jobs in the Cloud Run deployer.
User facing changes (remove if N/A)
The Cloud Run deployer will deploy a Job if provided with a manifest for one.
Follow-up Work (remove if N/A)