fix: reverse order of deployers during cleanup (#7284) (backport v1) #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronicc
changed the title
chronicc
force-pushed
the
reverse-cleanup-order-backport-v1
branch
from
a6f8c9e to
3b14aa0
Compare
Codecov Report
@@ Coverage Diff @@
## v1 #7927 +/- ##
=====================================
Coverage ? 68.38%
=====================================
Files ? 563
Lines ? 26699
Branches ? 0
=====================================
Hits ? 18259
Misses ? 7173
Partials ? 1267 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chronicc
force-pushed
the
reverse-cleanup-order-backport-v1
branch
from
3b14aa0 to
9bb5a0d
Compare
|
I moved the reversal function into it's own method and added tests. |
gsquared94
reviewed
Oct 12, 2022
chronicc
force-pushed
the
reverse-cleanup-order-backport-v1
branch
3 times, most recently
from
711190b to
55795fa
Compare
|
I see, that I updated the wrong function in the rush of backporting it. Will fix this now. |
chronicc
force-pushed
the
reverse-cleanup-order-backport-v1
branch
from
55795fa to
382358c
Compare
.tool-versions is used by asdf (package manager) to set the go version for this repository
chronicc
force-pushed
the
reverse-cleanup-order-backport-v1
branch
from
382358c to
3602642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7284
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
Add a new deployer slice during cleanup function of the DeployerMux which is reversed in it's order. This change should be covered by the existing unittests since no new function was added.
This is a backport for v1.
User facing changes (remove if N/A)
Before:
Modules are undeployed in the same order as they are deployed. Visible in the console as
After:
Modules are undeployed in reverse order.