Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct issue where skaffold setTemplateValues env vars were in some cases empty #8261

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Dec 20, 2022

fixes #8252
fixes #8260
fixes #8262

requirement for v2.0.4 release

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #8261 (b359e60) into main (290280e) will decrease coverage by 4.36%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##             main    #8261      +/-   ##
==========================================
- Coverage   70.48%   66.12%   -4.37%     
==========================================
  Files         515      601      +86     
  Lines       23150    29491    +6341     
==========================================
+ Hits        16317    19500    +3183     
- Misses       5776     8529    +2753     
- Partials     1057     1462     +405     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 405 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit b166d34 into GoogleContainerTools:main Dec 20, 2022
aaron-prindle added a commit to aaron-prindle/skaffold that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants