Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for new runtimeType field #8298

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

gsquared94
Copy link
Contributor

Merge after: #8295

Description

Update docs for #8295

@aaron-prindle
Copy link
Contributor

I think tests will pass now that #8295 is merged if you rebase

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #8298 (f78c0f2) into main (290280e) will decrease coverage by 4.41%.
The diff coverage is 54.96%.

@@            Coverage Diff             @@
##             main    #8298      +/-   ##
==========================================
- Coverage   70.48%   66.06%   -4.42%     
==========================================
  Files         515      603      +88     
  Lines       23150    29556    +6406     
==========================================
+ Hits        16317    19526    +3209     
- Misses       5776     8565    +2789     
- Partials     1057     1465     +408     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 411 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsquared94 gsquared94 merged commit 420b790 into GoogleContainerTools:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants