chore: Update skaffold base image #8460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8460 +/- ##
==========================================
- Coverage 70.48% 65.21% -5.27%
==========================================
Files 515 603 +88
Lines 23150 29898 +6748
==========================================
+ Hits 16317 19498 +3181
- Misses 5776 8924 +3148
- Partials 1057 1476 +419
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Mar 1, 2023
* chore: Revert "chore: change skaffold base image (GoogleContainerTools#8433)" This reverts commit 6b3f673. * chore: update skaffold base image to ubuntu:20.04 * chore: add noninteractive (cherry picked from commit 9847653)
aaron-prindle
added a commit
that referenced
this pull request
Mar 1, 2023
* chore: upgrade go in dockerfile (#8420) (cherry picked from commit 6289a4b) * chore: Update skaffold base image (#8460) * chore: Revert "chore: change skaffold base image (#8433)" This reverts commit 6b3f673. * chore: update skaffold base image to ubuntu:20.04 * chore: add noninteractive (cherry picked from commit 9847653) --------- Co-authored-by: ericzzzzzzz <102683393+ericzzzzzzz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8418
related: #8418
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Test Plan
docker build \ -f deploy/skaffold/Dockerfile.deps \ -t abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8 \ .abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8cp deploy/skaffold/Dockerfile .to copy dockerfile to working directorydocker build -t your_repo:image_name --target builder .docker push your_repo:image_namedocker run --rm -v /var/run/docker.sock:/var/run/docker.sock -e DOCKER_CONFIG=/root/.docker your_repo:image_name make integration-teststo run tests with the new image, we can exit container after seeing a few success.