Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused helm fields and methods from v1 -> v2 migration #8461

Merged

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #8461 (5cc553c) into main (290280e) will decrease coverage by 5.28%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8461      +/-   ##
==========================================
- Coverage   70.48%   65.21%   -5.28%     
==========================================
  Files         515      602      +87     
  Lines       23150    29882    +6732     
==========================================
+ Hits        16317    19487    +3170     
- Misses       5776     8922    +3146     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 5ff2764 into GoogleContainerTools:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants