Remove duplication in kustomize deployer

[dgageot]

No description provided.

[codecov-io]

Codecov Report

Merging #900 into master will decrease coverage by 0.82%.
The diff coverage is 47.32%.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   38.27%   37.45%   -0.83%     
==========================================
  Files          56       58       +2     
  Lines        2576     2590      +14     
==========================================
- Hits          986      970      -16     
- Misses       1476     1509      +33     
+ Partials      114      111       -3

Impacted Files	Coverage Δ
pkg/skaffold/deploy/kubectl/warnings.go	0% <ø> (ø)
pkg/skaffold/deploy/kustomize.go	0% <0%> (ø)	⬆️
pkg/skaffold/deploy/kubectl/cli.go	0% <0%> (ø)
pkg/skaffold/deploy/kubectl/manifests.go	64.7% <64.7%> (ø)
pkg/skaffold/deploy/kubectl.go	50.61% <90%> (-14.97%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad07228...8a12a3a. Read the comment docs.

[balopat]

this looks good to me - is this in preparation for swapping out the image replacement logic with kustomize's logic?

[dgageot]

@balopat In my mind, it was just to remove some duplication but I'd be happy to do what you said. Can you explain me what you have in mind?

[balopat]

I'm not 100% sure that we can use this, but in kustomize 1.0.5 they introduced an ImageTagTransformer - would be interesting to check it out.

[balopat]

LGTM