Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify helm tests #957

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 7, 2018

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot requested review from balopat and r2d4 as code owners September 7, 2018 09:42
@dgageot dgageot force-pushed the simplify-helm-tests branch from d5a3dd2 to f375d6e Compare September 7, 2018 11:40
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the simplify-helm-tests branch from f375d6e to cac97b9 Compare September 7, 2018 11:49
@codecov-io
Copy link

codecov-io commented Sep 7, 2018

Codecov Report

Merging #957 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #957      +/-   ##
=========================================
+ Coverage   43.78%   43.8%   +0.02%     
=========================================
  Files          63      63              
  Lines        2654    2655       +1     
=========================================
+ Hits         1162    1163       +1     
  Misses       1370    1370              
  Partials      122     122
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 63.77% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4bf67...cac97b9. Read the comment docs.

@dgageot dgageot merged commit caa156c into GoogleContainerTools:master Sep 8, 2018
@dgageot dgageot deleted the simplify-helm-tests branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants