Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review E2E Testing Strategy #158

Closed
swissspidy opened this issue Jan 30, 2020 · 3 comments
Closed

Review E2E Testing Strategy #158

swissspidy opened this issue Jan 30, 2020 · 3 comments

Comments

@swissspidy
Copy link
Collaborator

While we focus on integration tests, we might want to have E2E tests to cover some aspects of the editor.

It should be easy to port this over from the previous editor when needed.

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Jan 30, 2020
@spacedmonkey
Copy link
Contributor

I think any drag and drop interaction would be good to test with e2e tests. I also think that video poster ( #135 ), would be a good one too.

swissspidy added a commit that referenced this issue Feb 17, 2020
@swissspidy
Copy link
Collaborator Author

Video poster extraction might be a nice candidate indeed, due do it definitely requiring a browser. Although we'd need to use something else than MP4 videos.

Regular drag & drop within the editor should be testable with React Testing Library. Even drag & drop of files might be possible, although there are some caveats (see testing-library/react-testing-library#339 (comment), jsdom/jsdom#1568)

That being said, we should identify the most critical areas to write tests for and figure out which kind of test is most suitable to cover those. We can start with issues labelled as bugs.


See #337 for current work on bringing back the e2e setup.

@jauyong jauyong added Pod:WPInfra and removed Type: Infrastructure Changes impacting testing infrastructure or build tooling labels May 15, 2020
@swissspidy
Copy link
Collaborator Author

Closing this one for now. Let's add e2e tests on an as-needed basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants