-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page grid view #58
Comments
Hey @barklund what exactly is this AC? Are you talking about the zoom slider?
|
Yes, it was referring to the preview thumbnail sizing. I have updated and clarified the text (and added deleting pages). Note that the AC does not include multi-select as we're still exploring if this is a P1 or later. |
I love this issue, having a grid mode will make layout control so much easier for users! One idea from a recent demo: how about enabling the grid mode automatically (or a "grid automatic mode") for specific interactions such as drag-and-drop or image resizing. In this mode, the grid isn't visible until until interaction - when a user starts resizing or dragging image for example, then the grid appears and interactions "snap" to it. Once the stop interacting, the grid disappears. |
@adamsilverstein I think this issue is more about a grid view as described in https://github.com/ampproject/amp-wp/issues/3974#issuecomment-572136169. Snapping is handled in ampproject/amp-wp#3773. |
@swissspidy - thanks for the link, that issue does cover my idea - I had missed it earlier when reviewing the issue backlog. |
Two open UX questions:
Current implementation: |
Here are answers to the UX question:
|
@samitron7 Sounds good. The three sizes are currently like this:
|
Hey @swissspidy are you able to add QA instructions for this? |
Added some, sorry for the delay! |
Feature description
Add a page grid view as a new global state for the entire editor as well as a button in the page carousel that enables it.
In grid view, show page outlines of all pages in story and allow them to be both dragged and cut-pasted as designed.
Page reordering/duplication takes immediate effect.
Page outlines can be resized using the slider in the footer.
The close button in the footer will close grid view (changes have been persisted instantly when made).
This ticket does not include showing actual previews of the pages in the grid view.
The keyboard interactions are dependent on the outcome of ampproject/amp-wp#3826.
This is still pending UX review.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: