-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard handling #3826
Comments
We need to be careful about making sure the text edit mode does not collide with keyboard shortcuts. |
I think there are a different set of handlerings depending on if an element is selected or not. When a element is selected I would expect the following.
When an element is selected in the media library
When a form element is selected in the sidebar.
Globally Should DETELE / backspace remove the current page? Maybe after confirming with a dialog? Should all deleting of elements via DELETE / backspace require confirmation. |
To clarify, copy/paste are probably not the keyboard actions, but the direct Initially, it'd seem, for the canvas specifically, it'd be more convenient to have a single set of keyboard/clipboard handlers. But in the current model it might be hard to dispatch all types of actions.
As far as cross-section keyboard mapping: not yet sure. I.e. perhaps Canvas needs to have its own keyboard/clipboard handler, and the side panel, media panel, etc - their own? The focus-based event handling could be more composeable for separate big panels. |
This is the one issue that we missed during the migration. Manually added it as GoogleForCreators/web-stories-wp#119 now. Please use that one for further conversations. |
Feature description
We need either to have:
Weigh pros and cons between the two solutions, get consensus and implement.
This is not about creating the actual keyboard shortcuts, but about creating the framework for adding them later.
Ping me @barklund, if you need more details on this.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: