Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips #66

Closed
barklund opened this issue Nov 27, 2019 · 0 comments · Fixed by #469
Closed

Tooltips #66

barklund opened this issue Nov 27, 2019 · 0 comments · Fixed by #469
Assignees
Labels
P1 High priority, must do soon

Comments

@barklund
Copy link
Contributor

Feature description

Add tooltips in a architectural clever way.

Screen Shot 2019-11-27 at 10 14 25 AM

Ignore shortcut texts for now, they'll come later (among other things depending on ampproject/amp-wp#3826).

Architecture could be a new top-level tooltip service and a useTooltip hook exposing a showTooltip function that accepts a DOM element and a string.

Alternatively it could be an element, that buttons and icons can be wrapped in such as:

  <Tooltip text="Duplicate page">
    <Button icon="trash" />
  </Tooltip>

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Implement a system to show tooltips.
  • Use this system to show a tooltip for "Delete page" and "Duplicate page" (only those two buttons at this point).
  • Tooltips are anchored to the button in a fixed offset (potentially shifts side to fit within the viewport).
  • Tooltips show on hover using a mouse or on focus using a keyboard or assistive device.

Implementation brief

QA testing instructions

Demo

Changelog entry

@swissspidy swissspidy transferred this issue from ampproject/amp-wp Jan 23, 2020
@swissspidy swissspidy added In Feature Map P1 High priority, must do soon labels Jan 23, 2020
@wassgha wassgha self-assigned this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority, must do soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants