-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reordering in page carousel #59
Comments
Focus work is partially done in ampproject/amp-wp#3826 and is dependent on that ticket. |
@barklund @dvoytenko @spacedmonkey @swissspidy Added a short implementation brief, this does not have a PoC yet but will start creating it now and move this issue to In Progress if there are no objections to the general approach (creating a generally usable |
As mentioned in last meeting, PoC should be simple and not be final code. Is it required here, IB seem pretty simple as it is reimplementing existing functionality |
@barklund I'm actually thinking now that since ampproject/amp-wp#3897 is already handling the focus then it makes sense not to block this issue and just implement the missing part here (reordering via carousel). Thoughts? |
Feature description
Allow pages in carousel to receive focus if clicked (as well as switch current page on the canvas above) and reordering if dragged.
Pages need not be focused first in order to be dragged.
There are some open issues around keyboard navigation (changing focus only or changing page as well) and similarly for keyboard-only reordering (maybe shift-arrow to move a page to the right or left in the order?).
This does not include page grid view or page grid view button.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
NB: Focusing will be handled separately, ignore the following focus-related points!
1a. This will of course still also change current page to the clicked one
1b. Clicking anywhere else on the page removes focus from pages
Implementation brief
tabindex
and:focus
for focus for accessibility and ease of implementation.Create a new
DropZone
component which will be used to wrap the element that needs dropzone.The
DropZone
implementation will have a placeholder for files drop as well but only implement general onDrop functionalityEach Page icon below the Pages () will be wrapped into DropZone which will then decide where should the Page be dropped.
Determine approach and UX for reordering with keyboard (dependent on Implement keyboard and focus management ampproject/amp-wp#3897).
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: