Shopping: Products JSON Schema Validation #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timarney
force-pushed
the
feature/woocommerce
branch
3 times, most recently
from
f0142e4 to
bb56e22
Compare
timarney
added
Pod: WP
Type: Infrastructure
|
Noting this was failing on WP 5.5 -- not sure if that's a plugin issue or something else happening. For now I have wrapped a WP latest check around the install. |
timarney
added
Group: Shopping
timarney
commented
Apr 18, 2022
timarney
changed the title
timarney
force-pushed
the
feature/woocommerce
branch
4 times, most recently
from
5e56f9f to
8b7d7b0
Compare
timarney
commented
Apr 20, 2022
timarney
commented
Apr 20, 2022
timarney
force-pushed
the
feature/woocommerce
branch
from
8b7d7b0 to
0916a61
Compare
swissspidy
reviewed
Apr 20, 2022
timarney
force-pushed
the
feature/woocommerce
branch
from
265f14f to
08876dd
Compare
|
Hmm alright, then I didn‘t look close enough. Will re-check on Monday. |
8 tasks
|
@swissspidy I tested locally with your composer update commit merged back to this one it's s now working as expected (fails on the schema check string vs number) |
swissspidy
reviewed
Apr 26, 2022
Okay and which schema check is exactly failing? Can we fix our code? I only see this error message: |
Right for CI --- need to investigate why it's not finding that selector Locally for me I'm getting a schema error because product price is returning a string vs the schema is looking for a number. So yes that part can be fixed --- but maybe that fix should be in the product query PR? |
Works for me; just keep in mind that then the test needs to be disabled until that gets fixed. |
swissspidy
reviewed
Apr 26, 2022
|
Size Change: +5 B (0%) Total Size: 2.6 MB ℹ️ View Unchanged
|
|
Plugin builds for 17ea300 are ready 🛎️!
|
|
@timarney Heads up! Currently working on some updates to help make the tests a bit less flakey. Please do not rebase/override my changes. |
|
All e2e tests seem to be passing now! 🎉 |
swissspidy
approved these changes
Apr 27, 2022
|
@spacedmonkey ping 👋 to review the latest version of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In support of #11210 we need make the WoocCommerce plugin available with some sample products to query against to ensure a valid JSON schema is returned.
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
npm run env:startThis PR can be tested by following these steps:
npm run env:start--- this should install WooCommerce + sample productsReviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRPartially addresses #11210