Configure Jest for TypeScript #12167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
swissspidy
commented
Aug 30, 2022
swissspidy
added
Package: Tracking
swissspidy
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
commented
Nov 2, 2022
|
|
||
| if (!sizes) { | ||
| return normalizedSizes; | ||
| } | ||
|
|
||
| for (const size of Object.keys(sizes)) { | ||
| const data = sizes[size]; | ||
|
|
||
| if (!data.width || !data.height || !data.sourceUrl) { |
There was a problem hiding this comment.
This might help with #12485, because that one looks like an issue with trying to do replaceAll() an undefined/null sourceUrl
|
Size Change: +96 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
spacedmonkey
reviewed
Nov 4, 2022
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import type { OrderedSet } from 'immutable'; |
There was a problem hiding this comment.
Isn't this external dependencies
There was a problem hiding this comment.
In tests. Is there any downside to this?
spacedmonkey
approved these changes
Nov 4, 2022
timarney
approved these changes
Nov 4, 2022
merapi
approved these changes
Nov 4, 2022
barklund
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
So that we can write tests in TypeScripts if desired. See #12097
Summary
Relevant Technical Choices
To-do
User-facing changes
None
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12097