-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use auto-save for preview #1247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +13.8 kB (1%) Total Size: 836 kB
ℹ️ View Unchanged
|
miina
commented
Apr 16, 2020
swissspidy
reviewed
Apr 16, 2020
miina
requested review from
barklund,
dvoytenko and
spacedmonkey
as code owners
April 16, 2020 14:13
miina
commented
Apr 16, 2020
Closed
swissspidy
reviewed
Apr 20, 2020
On the todo, maybe we could trigger an autosave when user tries to leave the page. |
barklund
reviewed
Apr 20, 2020
dvoytenko
suggested changes
Apr 21, 2020
dvoytenko
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on my side.
swissspidy
added
the
Type: Enhancement
New feature or improvement of an existing feature
label
Apr 28, 2020
obetomuniz
added a commit
that referenced
this pull request
Apr 28, 2020
* master: (85 commits) Bump puppeteer from 3.0.1 to 3.0.2 (#1359) Bump @svgr/webpack from 5.3.1 to 5.4.0 (#1352) Bump jest-matcher-deep-close-to from 1.3.0 to 2.0.0 (#1351) Use relative paths for lint-staged (#1357) Allow php nightly tests to fail (#1356) Update list of Google Fonts (#1345) Bump commander from 5.0.0 to 5.1.0 (#1344) Updated Build and Continuous Integration Tooling (#1096) Bump use-debounce from 3.4.1 to 3.4.2 (#1334) Bump terser-webpack-plugin from 2.3.5 to 2.3.6 (#1338) Bump @testing-library/dom from 7.2.1 to 7.2.2 (#1336) removing unnecessary returns fixing unnecessary returns and removing unused mock in useStoryApi test per carlos feedback Bump css-loader from 3.5.2 to 3.5.3 (#1332) cleaning up unecessary values getting passed to useStoryApi moving story related actions to their own useStoryApi file in provider to clean up apiProvider file, doing the same for fonts. Add catch block to mocked requests Use auto-save for preview (#1247) Unskip tests (#1327) Revert "Update tests" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1149
Does the following:
auto-save
for the preview when previewing a non-draft post.Todo for #221: