Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto-save for preview #1247

Merged
merged 19 commits into from
Apr 24, 2020
Merged

Use auto-save for preview #1247

merged 19 commits into from
Apr 24, 2020

Conversation

miina
Copy link
Contributor

@miina miina commented Apr 16, 2020

Fixes #1149

Does the following:

  • Uses the correct preview link for preview
  • Creates an auto-save for the preview when previewing a non-draft post.

Todo for #221:

  • Auto-saving every 60 seconds
  • Ensuring that story data JSON representation gets saved, too (not needed for previewing).

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2020

Size Change: +13.8 kB (1%)

Total Size: 836 kB

Filename Size Change
assets/css/stories-dashboard.css 3.02 kB +21 B (0%)
assets/js/edit-story.js 450 kB +4.5 kB (1%)
assets/js/stories-dashboard.js 380 kB +9.3 kB (2%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.04 kB 0 B

compressed-size-action

@miina miina marked this pull request as ready for review April 16, 2020 14:13
@jauyong jauyong mentioned this pull request Apr 16, 2020
@spacedmonkey
Copy link
Contributor

On the todo, maybe we could trigger an autosave when user tries to leave the page.

@miina miina requested a review from dvoytenko April 23, 2020 09:09
Copy link
Contributor

@dvoytenko dvoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my side.

@miina miina merged commit 0add363 into master Apr 24, 2020
@miina miina deleted the fix/1149-preview branch April 24, 2020 07:02
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Apr 28, 2020
obetomuniz added a commit that referenced this pull request Apr 28, 2020
* master: (85 commits)
  Bump puppeteer from 3.0.1 to 3.0.2 (#1359)
  Bump @svgr/webpack from 5.3.1 to 5.4.0 (#1352)
  Bump jest-matcher-deep-close-to from 1.3.0 to 2.0.0 (#1351)
  Use relative paths for lint-staged (#1357)
  Allow php nightly tests to fail (#1356)
  Update list of Google Fonts (#1345)
  Bump commander from 5.0.0 to 5.1.0 (#1344)
  Updated Build and Continuous Integration Tooling (#1096)
  Bump use-debounce from 3.4.1 to 3.4.2 (#1334)
  Bump terser-webpack-plugin from 2.3.5 to 2.3.6 (#1338)
  Bump @testing-library/dom from 7.2.1 to 7.2.2 (#1336)
  removing unnecessary returns
  fixing unnecessary returns and removing unused mock in useStoryApi test per carlos feedback
  Bump css-loader from 3.5.2 to 3.5.3 (#1332)
  cleaning up unecessary values getting passed to useStoryApi
  moving story related actions to their own useStoryApi file in provider to clean up apiProvider file, doing the same for fonts.
  Add catch block to mocked requests
  Use auto-save for preview (#1247)
  Unskip tests (#1327)
  Revert "Update tests"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview of the published story
6 participants