Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Add new dropdown for choosing analytics behavior #13567

Merged
merged 33 commits into from
Feb 16, 2024
Merged

Settings: Add new dropdown for choosing analytics behavior #13567

merged 33 commits into from
Feb 16, 2024

Commits on Jan 17, 2024

  1. ✨ Register Tracking Handler Setting

    @AnuragVasanwala
    AnuragVasanwala committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    169b5ae View commit details
    Browse the repository at this point in the history

  2. ♻️ Refactor SiteKit actions and filters on register for flexibl… 

    …e tracking handler
    @AnuragVasanwala
    AnuragVasanwala committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ae0b9f9 View commit details
    Browse the repository at this point in the history

  3. ✨ Register Tracking Handler API for wp-dashboard

    @AnuragVasanwala
    AnuragVasanwala committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e45af01 View commit details
    Browse the repository at this point in the history

  4. 🖍 Register new setting UI with dropdown for flexible Tracking Handler… 

    … selection

This dropdown will only be visible when SiteKit is installed & active.
    @AnuragVasanwala
    AnuragVasanwala committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7eb0e5a View commit details
    Browse the repository at this point in the history

  5. 🏗 Add missing doc comment for parameter $settings

    @AnuragVasanwala
    AnuragVasanwala committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1272da3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. ♻️ Refactor messages for translation markup

    @AnuragVasanwala
    AnuragVasanwala committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9b6eae3 View commit details
    Browse the repository at this point in the history

  2. 🧪 Update editorSettings unit-test to support for analytics dropdown

    @AnuragVasanwala
    AnuragVasanwala committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    cba190c View commit details
    Browse the repository at this point in the history

  3. 🧪 Update Site_Kit unit-test to support for newly added Setting pa… 

    …rameter to the constructor
    @AnuragVasanwala
    AnuragVasanwala committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7049147 View commit details
    Browse the repository at this point in the history

  4. 🧪 Add unit-test to Site_Kit to support for switching between SiteKi… 

    …t and GA
    @AnuragVasanwala
    AnuragVasanwala committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0d8d898 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/13506-flexible-tracking-support

    @AnuragVasanwala
    AnuragVasanwala authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7ada51c View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge branch 'main' into feat/13506-flexible-tracking-support

    @AnuragVasanwala
    AnuragVasanwala authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3234d7b View commit details
    Browse the repository at this point in the history

  2. ⏪ Revert added PHPUnit tests in Site_Kit

    @AnuragVasanwala
    AnuragVasanwala committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    860c1b0 View commit details
    Browse the repository at this point in the history

  3. 🧪 Add E2E unit tests for Site_Kit

    @AnuragVasanwala
    AnuragVasanwala committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    82a7b4a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feat/13506-flexible-tracking-support' of https://github… 

    ….com/GoogleForCreators/web-stories-wp into feat/13506-flexible-tracking-support
    @AnuragVasanwala
    AnuragVasanwala committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ccb8df3 View commit details
    Browse the repository at this point in the history

  5. ♻️ Display Site_Kit note only when it is active

    @AnuragVasanwala
    AnuragVasanwala committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9481a77 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch 'main' into feat/13506-flexible-tracking-support

    @AnuragVasanwala
    AnuragVasanwala authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e561801 View commit details
    Browse the repository at this point in the history

  2. Remove e2e tests that check if SiteKit message is displayed

    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a198f99 View commit details
    Browse the repository at this point in the history

  3. Add component tests for <GoogleAnalyticsSettings />: 

    1. Check if dropdown has rendered
2. Check if SiteKit specific message is displayed
3. Check if `handleUpdateGoogleAnalyticsHandler` is called with the appropriate values
    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    383dee8 View commit details
    Browse the repository at this point in the history

  4. Export ANALYTICS_DROPDOWN_OPTIONS to be used in tests

    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5fbcae4 View commit details
    Browse the repository at this point in the history

  5. Remove unused constants

    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    00d77d1 View commit details
    Browse the repository at this point in the history

  6. Fix eslint issues

    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0682753 View commit details
    Browse the repository at this point in the history

  7. Fix phpcs issues

    @Swanand01
    Swanand01 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    38ce65c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. 🐛 Fix: Restrict tracking-id input only when analyticsActive is acti… 

    …ve and `analyticsHandler` is `site-kit`
    @AnuragVasanwala
    AnuragVasanwala committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c8fe3bd View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix eslint issues in googleAnalytics/index.js

    @Swanand01
    Swanand01 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    9e597ee View commit details
    Browse the repository at this point in the history

  2. Add tests to check if the Google Anaytics ID input is enabled/disable… 

    …d on changing the dropdown option
    @Swanand01
    Swanand01 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6169d7e View commit details
    Browse the repository at this point in the history

  3. Update Site Kit note text and display it regardless of option chosen … 

    …in dropdown
    @Swanand01
    Swanand01 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    b86ae3c View commit details
    Browse the repository at this point in the history

  4. Update tests for the Site Kit note

    @Swanand01
    Swanand01 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    cdfaf7d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Remove restriction where measurement ID field is disabled when the "… 

    …Use Site Kit" option is chosen
    @Swanand01
    Swanand01 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3062d10 View commit details
    Browse the repository at this point in the history

  2. Update tests for measurement ID input

    @Swanand01
    Swanand01 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    da44dba View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/13506-flexible-tracking-support

    @Swanand01
    Swanand01 authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8021238 View commit details
    Browse the repository at this point in the history

  4. Remove disable restriction for measurement ID input

    @Swanand01
    Swanand01 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1133448 View commit details
    Browse the repository at this point in the history

  5. Remove redundant test that checked if the measurement ID input is ena… 

    …bled
    @Swanand01
    Swanand01 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8851a7b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feat/13506-flexible-tracking-support' of https://github… 

    ….com/GoogleForCreators/web-stories-wp into feat/13506-flexible-tracking-support
    @Swanand01
    Swanand01 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8b792a2 View commit details
    Browse the repository at this point in the history