-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if running plugin from source #2962
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
+ Coverage 81.22% 82.02% +0.80%
==========================================
Files 714 718 +4
Lines 12016 12068 +52
==========================================
+ Hits 9760 9899 +139
+ Misses 2256 2169 -87
|
Size Change: -1.26 kB (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
Did you consider using |
bbedb19
to
d7df835
Compare
d7df835
to
a744d10
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@swissspidy This is good to go! |
Summary
Warn users if they forgot to run the build commands.
Helpful if someone just downloads the current master branch as a ZIP file and expects the plugin to "just work".
Relevant Technical Choices
Uses an anonymous function because this cannot really be covered by unit tests and this shouldn't be disabled by others.
To-do
User-facing changes
Testing Instructions
Download the master branch and try to install the plugin on a fresh install, or simply remove the
vendor
folder to force the admin notice from appearing.Fixes #1234
See #2961