Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to puppeteer 9.1.1 #7390

Merged
merged 9 commits into from
May 6, 2021
Merged

Upgrade to puppeteer 9.1.1 #7390

merged 9 commits into from
May 6, 2021

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented May 5, 2021 •
edited
Loading

Context

Summary

Upgrade to puppeteer 9.1.1

Relevant Technical Choices

Requires npm install --force and installing of "@axe-core/puppeteer": "^4.1.2-alpha.118",

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #6876

@spacedmonkey spacedmonkey self-assigned this May 5, 2021
@google-cla google-cla bot added the cla: yes label May 5, 2021
@spacedmonkey
Copy link
Contributor Author

I believe the issue is @axe-core/puppeteer see.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: puppeteer@9.1.1
npm ERR! node_modules/puppeteer
npm ERR!   dev puppeteer@"^9.1.0" from the root project
npm ERR!   peer puppeteer@">=1.19.0" from @wordpress/e2e-test-utils@5.1.1
npm ERR!   node_modules/@wordpress/e2e-test-utils
npm ERR!     @wordpress/e2e-test-utils@"^5.1.1" from e2e-test-utils@undefined
npm ERR!     packages/e2e-test-utils
npm ERR!     dev @wordpress/e2e-test-utils@"^5.1.1" from e2e-tests@undefined
npm ERR!     packages/e2e-tests
npm ERR!   2 more (@wordpress/jest-puppeteer-axe, @percy/puppeteer)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer puppeteer@">=1.10.0 < 6" from @axe-core/puppeteer@4.1.1
npm ERR! node_modules/@axe-core/puppeteer
npm ERR!   @axe-core/puppeteer@"^4.0.0" from @wordpress/jest-puppeteer-axe@3.0.2
npm ERR!   node_modules/@wordpress/jest-puppeteer-axe
npm ERR!     dev @wordpress/jest-puppeteer-axe@"^3.0.2" from e2e-tests@undefined
npm ERR!     packages/e2e-tests
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/jonny/.npm/eresolve-report.txt for a full report.

@axe-core/puppeteer only added support for puppeteer 9.0.0 19 hours ago in dequelabs/axe-core-npm#242.

@swissspidy ^

@swissspidy
Copy link
Collaborator

Installing @axe-core/puppeteer@next (currently pointing at 4.1.2-alpha.118) should resolve that, it was published 3 ours ago.

swissspidy
swissspidy reviewed May 5, 2021
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed May 5, 2021
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 2.18 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/carousel-view-rtl.css 715 B 0 B
assets/css/carousel-view.css 716 B 0 B
assets/css/edit-story-rtl.css 278 B 0 B
assets/css/edit-story.css 278 B 0 B
assets/css/stories-dashboard-rtl.css 276 B 0 B
assets/css/stories-dashboard.css 276 B 0 B
assets/css/vendors-edit-story-rtl.css 702 B 0 B
assets/css/vendors-edit-story.css 702 B 0 B
assets/css/web-stories-block-rtl.css 3.23 kB 0 B
assets/css/web-stories-block.css 3.26 kB 0 B
assets/css/web-stories-embed-rtl.css 284 B 0 B
assets/css/web-stories-embed.css 284 B 0 B
assets/css/web-stories-list-styles-rtl.css 2.26 kB 0 B
assets/css/web-stories-list-styles.css 2.27 kB 0 B
assets/css/web-stories-theme-style-twentyeleven-rtl.css 102 B 0 B
assets/css/web-stories-theme-style-twentyeleven.css 102 B 0 B
assets/css/web-stories-theme-style-twentyfifteen-rtl.css 252 B 0 B
assets/css/web-stories-theme-style-twentyfifteen.css 252 B 0 B
assets/css/web-stories-theme-style-twentyfourteen-rtl.css 286 B 0 B
assets/css/web-stories-theme-style-twentyfourteen.css 286 B 0 B
assets/css/web-stories-theme-style-twentyseventeen-rtl.css 311 B 0 B
assets/css/web-stories-theme-style-twentyseventeen.css 311 B 0 B
assets/css/web-stories-theme-style-twentysixteen-rtl.css 239 B 0 B
assets/css/web-stories-theme-style-twentysixteen.css 239 B 0 B
assets/css/web-stories-theme-style-twentyten-rtl.css 144 B 0 B
assets/css/web-stories-theme-style-twentyten.css 145 B 0 B
assets/css/web-stories-theme-style-twentytwelve-rtl.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwelve.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwenty-rtl.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwenty.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwentyone-rtl.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwentyone.css 265 B 0 B
assets/css/web-stories-widget-rtl.css 489 B 0 B
assets/css/web-stories-widget.css 489 B 0 B
assets/js/carousel-view.js 3.72 kB 0 B
assets/js/chunk-fonts-********************.js 45.4 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 7.05 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 8.58 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 7.92 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 8.73 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 9.8 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.12 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 8.17 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 7.93 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.29 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.87 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 7.92 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 15.4 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.43 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 5.71 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 5.5 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 10.4 kB 0 B
assets/js/edit-story.js 520 kB 0 B
assets/js/lightbox.js 986 B 0 B
assets/js/stories-dashboard.js 440 kB 0 B
assets/js/tinymce-button.js 3.48 kB 0 B
assets/js/vendors-chunk-ffmpeg-********************.js 5.61 kB 0 B
assets/js/vendors-edit-story-********************.js 61.4 kB 0 B
assets/js/vendors-edit-story-stories-dashboard-********************.js 277 kB 0 B
assets/js/web-stories-activation-notice.js 70 kB 0 B
assets/js/web-stories-block.js 605 kB 0 B
assets/js/web-stories-embed.js 492 B 0 B
assets/js/web-stories-widget.js 984 B 0 B

compressed-size-action

@spacedmonkey spacedmonkey marked this pull request as ready for review May 5, 2021 15:05
@spacedmonkey spacedmonkey added Package: E2E Test Utils /packages/e2e-test-utils Package: E2E Tests /packages/e2e-tests FIXIT Type: Infrastructure Changes impacting testing infrastructure or build tooling labels May 5, 2021
@spacedmonkey
Copy link
Contributor Author

This PR is blocked by #7289.

@swissspidy
Copy link
Collaborator

Publishing flow tests seem to be still flakey, even after #7289 being merged

@spacedmonkey
Copy link
Contributor Author

@swissspidy It is now passing. I ran it twice and it works.

@swissspidy swissspidy merged commit 0378012 into main May 6, 2021
@swissspidy swissspidy deleted the puppeteer-update-3 branch May 6, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@spacedmonkey spacedmonkey

Labels
Package: E2E Test Utils /packages/e2e-test-utils Package: E2E Tests /packages/e2e-tests Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update puppeteer to latest version
2 participants
@spacedmonkey @swissspidy