Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure amp-video v0.1 is being used #8384

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Jul 20, 2021

Context

See #8364 for details.

We were accidentally adding v1.0 of amp-video instead of v0.1.

Summary

Updates PHP AMP sanitization to use amp-video v0.1 whenever missing.

Relevant Technical Choices

Ports over change and tests from ampproject/amp-wp#6303

Also updates @link references to point to v2.1.3 of the AMP plugin to make cross-referencing easier.

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Insert Tenor GIF
  2. Preview story
  3. Verify GIF (video) is visible and playing

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #8364

@swissspidy swissspidy added Type: Bug Something isn't working AMP Output Issues related to AMP output and validation Pod: WP & Infra labels Jul 20, 2021
@google-cla google-cla bot added the cla: yes label Jul 20, 2021
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 3.58 MB

ℹ️ View Unchanged
Filename Size
assets/css/carousel-view-rtl.css 701 B
assets/css/carousel-view.css 701 B
assets/css/edit-story-rtl.css 1.21 kB
assets/css/edit-story.css 1.2 kB
assets/css/stories-dashboard-rtl.css 625 B
assets/css/stories-dashboard.css 626 B
assets/css/web-stories-block-rtl.css 3.27 kB
assets/css/web-stories-block.css 3.3 kB
assets/css/web-stories-embed-rtl.css 288 B
assets/css/web-stories-embed.css 288 B
assets/css/web-stories-list-styles-rtl.css 2.3 kB
assets/css/web-stories-list-styles.css 2.32 kB
assets/css/web-stories-theme-style-twentyeleven-rtl.css 102 B
assets/css/web-stories-theme-style-twentyeleven.css 102 B
assets/css/web-stories-theme-style-twentyfifteen-rtl.css 251 B
assets/css/web-stories-theme-style-twentyfifteen.css 251 B
assets/css/web-stories-theme-style-twentyfourteen-rtl.css 287 B
assets/css/web-stories-theme-style-twentyfourteen.css 287 B
assets/css/web-stories-theme-style-twentyseventeen-rtl.css 288 B
assets/css/web-stories-theme-style-twentyseventeen.css 288 B
assets/css/web-stories-theme-style-twentysixteen-rtl.css 224 B
assets/css/web-stories-theme-style-twentysixteen.css 224 B
assets/css/web-stories-theme-style-twentyten-rtl.css 143 B
assets/css/web-stories-theme-style-twentyten.css 143 B
assets/css/web-stories-theme-style-twentytwelve-rtl.css 256 B
assets/css/web-stories-theme-style-twentytwelve.css 256 B
assets/css/web-stories-theme-style-twentytwenty-rtl.css 86 B
assets/css/web-stories-theme-style-twentytwenty.css 86 B
assets/css/web-stories-theme-style-twentytwentyone-rtl.css 325 B
assets/css/web-stories-theme-style-twentytwentyone.css 326 B
assets/css/web-stories-widget-rtl.css 484 B
assets/css/web-stories-widget.css 484 B
assets/js/carousel-view.js 3.72 kB
assets/js/chunk-focus-visible-********************.js 1 kB
assets/js/chunk-fonts-********************.js 45.9 kB
assets/js/chunk-web-stories-template-0-********************.js 475 B
assets/js/chunk-web-stories-template-10-********************.js 7.96 kB
assets/js/chunk-web-stories-template-100-********************.js 7.99 kB
assets/js/chunk-web-stories-template-102-********************.js 489 B
assets/js/chunk-web-stories-template-106-********************.js 7.78 kB
assets/js/chunk-web-stories-template-108-********************.js 430 B
assets/js/chunk-web-stories-template-112-********************.js 8.15 kB
assets/js/chunk-web-stories-template-114-********************.js 464 B
assets/js/chunk-web-stories-template-118-********************.js 13.8 kB
assets/js/chunk-web-stories-template-12-********************.js 491 B
assets/js/chunk-web-stories-template-120-********************.js 509 B
assets/js/chunk-web-stories-template-124-********************.js 8.33 kB
assets/js/chunk-web-stories-template-126-********************.js 445 B
assets/js/chunk-web-stories-template-130-********************.js 8.59 kB
assets/js/chunk-web-stories-template-16-********************.js 9.01 kB
assets/js/chunk-web-stories-template-18-********************.js 499 B
assets/js/chunk-web-stories-template-22-********************.js 7.94 kB
assets/js/chunk-web-stories-template-24-********************.js 462 B
assets/js/chunk-web-stories-template-28-********************.js 6.63 kB
assets/js/chunk-web-stories-template-30-********************.js 466 B
assets/js/chunk-web-stories-template-34-********************.js 7.81 kB
assets/js/chunk-web-stories-template-36-********************.js 479 B
assets/js/chunk-web-stories-template-4-********************.js 10.4 kB
assets/js/chunk-web-stories-template-40-********************.js 8.06 kB
assets/js/chunk-web-stories-template-42-********************.js 425 B
assets/js/chunk-web-stories-template-46-********************.js 9.68 kB
assets/js/chunk-web-stories-template-48-********************.js 479 B
assets/js/chunk-web-stories-template-52-********************.js 8.4 kB
assets/js/chunk-web-stories-template-54-********************.js 457 B
assets/js/chunk-web-stories-template-58-********************.js 8.51 kB
assets/js/chunk-web-stories-template-6-********************.js 471 B
assets/js/chunk-web-stories-template-60-********************.js 449 B
assets/js/chunk-web-stories-template-64-********************.js 6.95 kB
assets/js/chunk-web-stories-template-66-********************.js 490 B
assets/js/chunk-web-stories-template-70-********************.js 8.14 kB
assets/js/chunk-web-stories-template-72-********************.js 443 B
assets/js/chunk-web-stories-template-76-********************.js 9.2 kB
assets/js/chunk-web-stories-template-78-********************.js 462 B
assets/js/chunk-web-stories-template-82-********************.js 6.01 kB
assets/js/chunk-web-stories-template-84-********************.js 515 B
assets/js/chunk-web-stories-template-88-********************.js 7.14 kB
assets/js/chunk-web-stories-template-90-********************.js 488 B
assets/js/chunk-web-stories-template-94-********************.js 8.77 kB
assets/js/chunk-web-stories-template-96-********************.js 481 B
assets/js/chunk-web-stories-textset-0-********************.js 5.29 kB
assets/js/chunk-web-stories-textset-1-********************.js 6.81 kB
assets/js/chunk-web-stories-textset-2-********************.js 7.91 kB
assets/js/chunk-web-stories-textset-3-********************.js 15.4 kB
assets/js/chunk-web-stories-textset-4-********************.js 4.43 kB
assets/js/chunk-web-stories-textset-5-********************.js 5.71 kB
assets/js/chunk-web-stories-textset-6-********************.js 5.5 kB
assets/js/chunk-web-stories-textset-7-********************.js 10.4 kB
assets/js/edit-story.js 1.05 MB
assets/js/lightbox.js 991 B
assets/js/stories-dashboard.js 880 kB
assets/js/tinymce-button.js 3.48 kB
assets/js/vendors-chunk-ffmpeg-********************.js 5.6 kB
assets/js/vendors-chunk-resize-observer-polyfill-********************.js 2.55 kB
assets/js/vendors-chunk-resize-observer-polyfill-edit-story-********************.js 2.55 kB
assets/js/vendors-chunk-web-animations-js-********************.js 14.6 kB
assets/js/vendors-edit-story-stories-dashboard-********************.js 232 kB
assets/js/web-stories-activation-notice.js 65.1 kB
assets/js/web-stories-block.js 995 kB
assets/js/web-stories-embed.js 493 B
assets/js/web-stories-widget.js 984 B

compressed-size-action

Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@swissspidy swissspidy merged commit e353060 into main Jul 20, 2021
@swissspidy swissspidy deleted the fix/amp-spec-extension-versions branch July 20, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP Output Issues related to AMP output and validation Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GIF not playing with amp-video v1.0
2 participants