Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix click error due to undefined listener object #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wouterz
Copy link

@wouterz wouterz commented Mar 22, 2018

Checking if listeners is defined before accessing property and removing. Before setting new properties set empty object if it is undefined.

This is also noted in issue #407 . But does not include setting new listeners

Checking if listeners is defined before accessing property and removing. Before setting new properties set empty object if it is undefined.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@wouterz
Copy link
Author

wouterz commented Mar 22, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@wouterz wouterz closed this Mar 22, 2018
@wouterz wouterz changed the title Fix click error due to undefined listener object. Resolves #407 Fix click error due to undefined listener object Mar 22, 2018
@wouterz wouterz reopened this Mar 22, 2018
@iuliaL
Copy link

iuliaL commented Jan 20, 2020

Can you please merge this pr? Would be awesome. My app breaks due to this undefined.

@wouterz
Copy link
Author

wouterz commented Oct 7, 2022

Almost 4 years later, this still seems to be an issue. Any chance of this getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants