Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http download timeout #188

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: http download timeout #188

merged 1 commit into from
Aug 25, 2023

Conversation

monkeyWie
Copy link
Member

related: #185

@monkeyWie monkeyWie added the bug Something isn't working label Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20% 🎉

Comparison is base (e1684e7) 58.36% compared to head (b7322eb) 58.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   58.36%   58.57%   +0.20%     
==========================================
  Files          15       15              
  Lines        1828     1830       +2     
==========================================
+ Hits         1067     1072       +5     
+ Misses        636      634       -2     
+ Partials      125      124       -1     
Files Changed Coverage Δ
internal/protocol/http/fetcher.go 74.21% <100.00%> (+0.85%) ⬆️
pkg/download/downloader.go 52.29% <100.00%> (+0.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie merged commit b6d60f6 into main Aug 25, 2023
3 checks passed
@monkeyWie monkeyWie deleted the fix/http_download_timeout branch August 26, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants