Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .deb build #269

Merged
merged 30 commits into from
Nov 15, 2023
Merged

fix .deb build #269

merged 30 commits into from
Nov 15, 2023

Conversation

pugaizai
Copy link
Contributor

1.fix .deb build
2.upload a .svg icon

@pugaizai
Copy link
Contributor Author

要不顺便帮你把flatpak的包也打了

@pugaizai
Copy link
Contributor Author

还有个问题,github ci里的ubuntu 2204打出来的包需要"libstdc++.so.6: version `GLIBCXX_3.4.32' not found" 才能运行。
然而ubuntu 2204最高也只有GLIBCXX_3.4.30,需要添加那个ppa:ubuntu-tooltrain-r升级glibc版本才能打开

@monkeyWie
Copy link
Member

哇,好巧啊,这个分支刚好也在处理这事,等会我合并到主干上,我把 .desktop 文件抽出来了为了flatpak那边能复用,跟你pr的功能重叠比较多,麻烦你再重新看看,十分感谢!

题外话: svg icon怎么生成的,好想要,哈哈。

@pugaizai
Copy link
Contributor Author

pugaizai commented Nov 15, 2023

题外话: svg icon怎么生成的,好想要,哈哈。

拿你的 png 直接百度一个 png 转 svg 的网站生成的

@pugaizai
Copy link
Contributor Author

哇,好巧啊,这个分支刚好也在处理这事,等会我合并到主干上,我把 .desktop 文件抽出来了为了flatpak那边能复用,跟你pr的功能重叠比较多,麻烦你再重新看看,十分感谢!

我下午再看,先睡会儿

@monkeyWie
Copy link
Member

还有个问题,github ci里的ubuntu 2204打出来的包需要"libstdc++.so.6: version `GLIBCXX_3.4.32' not found" 才能运行。 然而ubuntu 2204最高也只有GLIBCXX_3.4.30,需要添加那个ppa:ubuntu-tooltrain-r升级glibc版本才能打开

我试试用ubuntu 20.04打包,这样应该就没问题了.

@pugaizai
Copy link
Contributor Author

pugaizai commented Nov 15, 2023

搞定了,你再看下@monkeyWie
我先上班去了

@pugaizai
Copy link
Contributor Author

Snap 那里的 sed 需要改下,我不太会 sed。
或者你也可以使用 desktop-file-edit 这个命令

@monkeyWie
Copy link
Member

@neovali 我已经合并到主干上了,帮忙拉下新代码再改一改。

desktop-file-edit 这个命令我试过,它修改成 ${SNAP} 的时候会报错,不支持特殊符号,所以换成sed了

@monkeyWie
Copy link
Member

我大体上都是按你这的代码改了下,剩下还有些国际化和icon的没改

@monkeyWie
Copy link
Member

另外那个flatpak的申请已经有个仓库了,如果你有兴趣也可以帮忙弄下哈,感谢~
仓库:https://github.com/GopeedLab/flathub/tree/new-pr
相关PR:flathub/flathub#4686

@pugaizai
Copy link
Contributor Author

pugaizai commented Nov 15, 2023

看看有没有什么问题,没问题的话合了我再搞flatpak @monkeyWie

@monkeyWie
Copy link
Member

为什么不用.svg做icon了呢

@pugaizai
Copy link
Contributor Author

为什么不用.svg做icon了呢

其实都行,无关紧要

@monkeyWie
Copy link
Member

还是帮忙换成.svg吧

@pugaizai
Copy link
Contributor Author

https://github.com/wger-project/flutter/tree/master/flatpak/scripts
有关flatpak,其实可以看看这个

@pugaizai
Copy link
Contributor Author

pugaizai commented Nov 15, 2023

或者把metainfo .desktop icon什么的上传到flathub那个repo里也行吧,fluffychat也是这么做的。看你怎么选
https://github.com/flathub/im.fluffychat.Fluffychat
照着抄就行,反正现在还不能在flatpak构建flutter软件

@monkeyWie
Copy link
Member

或者把metainfo .desktop icon什么的上传到flathub那个repo里也行吧,fluffychat也是这么做的。看你怎么选

flathub审核的时候说要从上游项目获取,就是得从这个仓库复制过去,但是那个metainfo我想还是直接上传过去,这样好做CI

@monkeyWie monkeyWie merged commit 848797b into GopeedLab:main Nov 15, 2023
2 checks passed
@monkeyWie
Copy link
Member

感谢,已经合并

@monkeyWie monkeyWie added the ci label Nov 28, 2023
@pugaizai
Copy link
Contributor Author

pugaizai commented Dec 3, 2023

GopeedLab/flathub#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants