feat: add docker permission related settings #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢感谢，我还堵在高速上呢，明天看看 |
没事，我也是第一次提交pr，明天你看看有没有问题 |
monkeyWie
reviewed
Feb 18, 2024
| apk upgrade --no-cache && \ | ||
| apk add --no-cache bash su-exec; \ | ||
| chmod +x ./entrypoint.sh && \ | ||
| rm -rf /var/cache/apk/* | ||
| VOLUME ["/app/storage"] | ||
| EXPOSE 9999 |
There was a problem hiding this comment.
我对比了下alist的dockerfile，这里少了一行ENV PUID=0 PGID=0 UMASK=022
monkeyWie
reviewed
Feb 18, 2024
entrypoint.sh
Outdated
Comment on lines
3
to
5
| mkdir /Downloads | ||
|
|
||
| chown -R ${PUID}:${PGID} /app /Downloads |
There was a problem hiding this comment.
下载目录是/root/Downloads，可以不用创建了，直接改成：
chown -R ${PUID}:${PGID} /root/Downloads
monkeyWie
reviewed
Feb 18, 2024
entrypoint.sh
Outdated
Comment on lines
9
to
13
| if [ "$#" -gt 0 ]; then | ||
| exec su-exec ${PUID}:${PGID} ./gopeed "$@" | ||
| else | ||
| exec su-exec ${PUID}:${PGID} ./gopeed | ||
| fi |
There was a problem hiding this comment.
这里的判断可以不要了，直接换成：
exec su-exec ${PUID}:${PGID} ./gopeed "$@"
monkeyWie
reviewed
Feb 18, 2024
|
我试了有问题，给gopeed设置普通用户权限后他会自己在根目录创建Downloads目录并设置为下载目录，手动改回/root/Downloads也没权限，即使我设置/root/Downloads所有者跟程序一样也不行，其他应该没问题了 |
|
我考虑了下，为了不同用户统一安装目录，下个版本把docker里的默认下载目录改成 |
|
根目录/Downloads作为默认下载目录可行吗？反正都要映射出来 |
这不是根本解决办法，等新版修改默认下载地址后再说吧 |
|
抱歉久等了，Docker构建默认下载目录改成 |
等我一下，时间有点久我有点忘了，先研究研究 |
看看这样应该ok了 |
|
LGTM |
monkeyWie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
给docker镜像添加了设置用户用户组umask功能