Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extension modifed the request header cause HTTP fetch crash #832

Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix: extension modifed the request header cause HTTP fetch crash #832

merged 1 commit into from
Dec 8, 2024

Conversation

monkeyWie
Copy link
Member

related: #831

@monkeyWie monkeyWie added the bug Something isn't working label Dec 4, 2024
@monkeyWie monkeyWie changed the title fix: HTTP fetch crash when modified request extra via extension fix: HTTP fetch crash when modified request header via extension Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.73%. Comparing base (85fe92a) to head (c7f2484).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocol/http/fetcher.go 0.00% 2 Missing and 1 partial ⚠️
pkg/download/extension.go 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          35       35           
  Lines        4464     4464           
=======================================
  Hits         2622     2622           
  Misses       1569     1569           
  Partials      273      273

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie changed the title fix: HTTP fetch crash when modified request header via extension fix: Extend modifed the request header cause HTTP fetch crash Dec 4, 2024
@monkeyWie monkeyWie changed the title fix: Extend modifed the request header cause HTTP fetch crash fix: extension modifed the request header cause HTTP fetch crash Dec 4, 2024
@monkeyWie monkeyWie merged commit f4876c8 into main Dec 8, 2024
9 of 10 checks passed
@monkeyWie monkeyWie deleted the fix/extension_modify_http_req branch December 8, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@monkeyWie