Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to filter investments by contract number #572

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

subiabre
Copy link
Member

@subiabre subiabre commented Nov 6, 2023

🎩 What? Why?

Admins have trouble looking up investments by project but contract numbers are easier to identify and remember, this PR allows them to quickly sort investments by the contract number.

Testing

Navigate to your local admin panel and in the "accounts" page, try the new filter with any existing contract on your database. Lookup is by exact matches.

📷 Screenshots

Contract number filter at admin accounts filters

♥️ Thank you!

@subiabre subiabre requested a review from davidbeig November 6, 2023 11:50
@subiabre subiabre self-assigned this Nov 6, 2023
Copy link
Member

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidbeig davidbeig merged commit 4d7e460 into live Nov 6, 2023
3 checks passed
@davidbeig davidbeig deleted the feature/invest_contract_filter branch November 6, 2023 15:35
davidbeig added a commit that referenced this pull request Nov 23, 2023
* create subscriptions menu for project dashboard (#555)

authored-by: David Igón <davidbenabarre@platoniq.net>

* Add subscriptions

* Add subscriptions to project dashboard

* Update database code

* Update dashboard subscription form

* Start updating subscriptions dashboard to add new subscription

* Basic subscription form on dashboard

* CRUD for subscriptions on project dashboard

* Add support for subscriptions via stripe payments

* Fix Stripe integration details

* Make stripe subscriptions be enabled via rewards

* Remove legacy integration

* Remove javascript related to previous subscription model

* Fix stripe integration PR comments

* Use abstract payment in stripe payment method

* Create pull_request_template.md (#569)

* Allow to filter investments by contract number (#572)

Co-authored-by: Daniel Subiabre <daniel.subiabre@platoniq.net>

* Fix Stripe webhook code

* Use yml webhook secret

* Add missing config

* Fix subscription gateway madness

* Add subscriptions to user dashboard

* Unify stripe subscription naming

* Allow users to list and cancel their stripe subscriptions

* Update subscription data vis

* Channel Call Faq layout (#574)

* fixes in NodeFaq model

* fixes in NodeFaqDownload model

* complete NodeFaqQuestion count filter for getList

* clean channel call faq view

* add id to faq questions sections to be able to navigate to them

* add new action to see all faqs for a channel

* move channel call faq partials to new folder

* fix styles for channel call faqs

* add a gap between columns in channel call faq layout

* center faq header

* Add channel favicon (#565)

* add favicon section to layout and append channel label as channel's favicon

* fix favicon link for channel call

* add calls for project and reward to get subscribable rewards for a given project

* add creator controller and first view

* add new copies for creator landing

* add posts for creator landing

* add strong to user name in creator landing

* add project section to creator layout

---------

Co-authored-by: Daniel Subiabre García <subiabrewd@gmail.com>
Co-authored-by: Daniel Subiabre <daniel.subiabre@platoniq.net>
Co-authored-by: roxu <rxnetwalker@users.noreply.github.com>
davidbeig added a commit that referenced this pull request Nov 23, 2023
* create subscriptions menu for project dashboard (#555)

authored-by: David Igón <davidbenabarre@platoniq.net>

* Add subscriptions

* Add subscriptions to project dashboard

* Update database code

* Update dashboard subscription form

* Start updating subscriptions dashboard to add new subscription

* Basic subscription form on dashboard

* CRUD for subscriptions on project dashboard

* Add support for subscriptions via stripe payments

* Fix Stripe integration details

* Make stripe subscriptions be enabled via rewards

* Remove legacy integration

* Remove javascript related to previous subscription model

* Fix stripe integration PR comments

* Use abstract payment in stripe payment method

* Create pull_request_template.md (#569)

* Allow to filter investments by contract number (#572)

Co-authored-by: Daniel Subiabre <daniel.subiabre@platoniq.net>

* Fix Stripe webhook code

* Use yml webhook secret

* Add missing config

* Fix subscription gateway madness

* Add subscriptions to user dashboard

* Unify stripe subscription naming

* Allow users to list and cancel their stripe subscriptions

* Update subscription data vis

* Channel Call Faq layout (#574)

* fixes in NodeFaq model

* fixes in NodeFaqDownload model

* complete NodeFaqQuestion count filter for getList

* clean channel call faq view

* add id to faq questions sections to be able to navigate to them

* add new action to see all faqs for a channel

* move channel call faq partials to new folder

* fix styles for channel call faqs

* add a gap between columns in channel call faq layout

* center faq header

* Add channel favicon (#565)

* add favicon section to layout and append channel label as channel's favicon

* fix favicon link for channel call

* Only let admins allow stripe and subscribables

* Redirect user to stripe checkout to purchase subscription

* Add 'creator' role

* Add commissions data and fix webhook status

---------

Co-authored-by: Daniel Subiabre García <subiabrewd@gmail.com>
Co-authored-by: Daniel Subiabre <daniel.subiabre@platoniq.net>
Co-authored-by: roxu <rxnetwalker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants