Issue #94: Created SG.py (This is a file that handles functionality for the Singapore locale) #108
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,223 @@ | ||
| from datetime import date, timedelta | ||
| from dateutil.easter import EASTER_WESTERN | ||
| from holidata.utils import SmartDayArrow | ||
| from .holidays import Country | ||
|
|
||
| class SG(Country): | ||
| id = "SG" | ||
| languages = ["en"] | ||
| default_lang = "en" | ||
| regions = [] | ||
| easter_type = EASTER_WESTERN | ||
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("New Year's Day") \ | ||
| .on(self.new_years_day) \ | ||
| .with_flags("NF") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Chinese New Year") \ | ||
| .on(self.chinese_new_year) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Chinese New Year (Second Day)") \ | ||
| .on(self.chinese_new_year_day2) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Good Friday") \ | ||
| .on("2 days before Easter") \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Labour Day") \ | ||
| .on(self.labour_day) \ | ||
| .with_flags("NF") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Hari Raya Puasa") \ | ||
| .on(self.hari_raya_puasa) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Vesak Day") \ | ||
| .on(self.vesak_day) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Hari Raya Haji") \ | ||
| .on(self.hari_raya_haji) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("National Day") \ | ||
| .on(self.national_day) \ | ||
| .with_flags("NF") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Deepavali") \ | ||
| .on(self.deepavali) \ | ||
| .with_flags("NRV") | ||
|
|
||
| self.define_holiday() \ | ||
| .with_name("Christmas Day") \ | ||
| .on(self.christmas_day) \ | ||
| .with_flags("NRF") | ||
|
|
||
| @staticmethod | ||
| def shift_to_monday_if_weekend(holiday_date): | ||
| """Shift the holiday to Monday if it falls on a Saturday or Sunday.""" | ||
| smart_date = SmartDayArrow.fromdate(holiday_date) | ||
| return smart_date.shift_to_weekday("monday", including=True).date() | ||
|
|
||
| @staticmethod | ||
| def new_years_day(year): | ||
| """Return the date of New Year's Day for the given year.""" | ||
| return SG.shift_to_monday_if_weekend(date(year, 1, 1)) | ||
|
|
||
| @staticmethod | ||
| def chinese_new_year(year): | ||
| """Return the date of Chinese New Year for the given year.""" | ||
| dates = { | ||
| 2011: date(2011, 2, 3), | ||
| 2012: date(2012, 1, 23), | ||
| 2013: date(2013, 2, 10), | ||
| 2014: date(2014, 1, 31), | ||
| 2015: date(2015, 2, 19), | ||
| 2016: date(2016, 2, 8), | ||
| 2017: date(2017, 1, 28), | ||
| 2018: date(2018, 2, 16), | ||
| 2019: date(2019, 2, 5), | ||
| 2020: date(2020, 1, 25), | ||
| 2021: date(2021, 2, 12), | ||
| 2022: date(2022, 2, 1), | ||
| 2023: date(2023, 1, 22), | ||
| 2024: date(2024, 2, 10), | ||
| 2025: date(2025, 1, 29), | ||
| 2026: date(2026, 2, 17) | ||
| } | ||
| return dates.get(year) | ||
|
|
||
| @staticmethod | ||
| def chinese_new_year_day2(year): | ||
| """Return the date of the second day of Chinese New Year.""" | ||
| first_day = SG.chinese_new_year(year) | ||
| return SG.shift_to_monday_if_weekend(first_day + timedelta(days=1)) if first_day else None | ||
|
|
||
| @staticmethod | ||
| def labour_day(year): | ||
| """Return the date of Labour Day for the given year.""" | ||
| return SG.shift_to_monday_if_weekend(date(year, 5, 1)) | ||
|
|
||
| @staticmethod | ||
| def hari_raya_puasa(year): | ||
| """Return the date of Hari Raya Puasa for the given year.""" | ||
| dates = { | ||
| 2011: date(2011, 8, 30), | ||
| 2012: date(2012, 8, 19), | ||
| 2013: date(2013, 8, 8), | ||
| 2014: date(2014, 7, 28), | ||
| 2015: date(2015, 7, 17), | ||
| 2016: date(2016, 7, 6), | ||
| 2017: date(2017, 6, 25), | ||
| 2018: date(2018, 6, 15), | ||
| 2019: date(2019, 6, 5), | ||
| 2020: date(2020, 5, 24), | ||
| 2021: date(2021, 5, 13), | ||
| 2022: date(2022, 5, 3), | ||
| 2023: date(2023, 4, 22), | ||
| 2024: date(2024, 4, 10), | ||
| 2025: date(2025, 3, 31), | ||
| 2026: date(2026, 3, 20) | ||
| } | ||
| holiday_date = dates.get(year) | ||
| if holiday_date and holiday_date.weekday() == 5: # Saturday | ||
| return holiday_date + timedelta(days=2) # Move to Monday | ||
| return holiday_date | ||
|
|
||
| @staticmethod | ||
| def vesak_day(year): | ||
| """Return the date of Vesak Day for the given year.""" | ||
| dates = { | ||
| 2011: date(2011, 5, 17), | ||
| 2012: date(2012, 5, 5), | ||
| 2013: date(2013, 5, 24), | ||
| 2014: date(2014, 5, 13), | ||
| 2015: date(2015, 6, 1), | ||
| 2016: date(2016, 5, 21), | ||
| 2017: date(2017, 5, 10), | ||
| 2018: date(2018, 5, 29), | ||
| 2019: date(2019, 5, 19), | ||
| 2020: date(2020, 5, 7), | ||
| 2021: date(2021, 5, 26), | ||
| 2022: date(2022, 5, 15), | ||
| 2023: date(2023, 6, 2), | ||
| 2024: date(2024, 5, 22), | ||
| 2025: date(2025, 5, 12), | ||
| 2026: date(2026, 5, 31) | ||
| } | ||
| return dates.get(year) | ||
|
|
||
| @staticmethod | ||
| def hari_raya_haji(year): | ||
| """Return the date of Hari Raya Haji for the given year.""" | ||
| dates = { | ||
| 2011: date(2011, 11, 6), | ||
| 2012: date(2012, 10, 26), | ||
| 2013: date(2013, 10, 15), | ||
| 2014: date(2014, 10, 5), | ||
| 2015: date(2015, 9, 24), | ||
| 2016: date(2016, 9, 12), | ||
| 2017: date(2017, 9, 1), | ||
| 2018: date(2018, 8, 22), | ||
| 2019: date(2019, 8, 11), | ||
| 2020: date(2020, 7, 31), | ||
| 2021: date(2021, 7, 20), | ||
| 2022: date(2022, 7, 10), | ||
| 2023: date(2023, 6, 29), | ||
| 2024: date(2024, 6, 17), | ||
| 2025: date(2025, 6, 7), | ||
| 2026: date(2026, 5, 27) | ||
| } | ||
| return dates.get(year) | ||
|
|
||
| @staticmethod | ||
| def national_day(year): | ||
| """Return the date of National Day for the given year.""" | ||
| return SG.shift_to_monday_if_weekend(date(year, 8, 9)) | ||
|
|
||
| @staticmethod | ||
| def deepavali(year): | ||
| """Return the date of Deepavali for the given year.""" | ||
| dates = { | ||
| 2011: date(2011, 10, 26), | ||
| 2012: date(2012, 11, 13), | ||
| 2013: date(2013, 11, 3), | ||
| 2014: date(2014, 10, 22), | ||
| 2015: date(2015, 11, 10), | ||
| 2016: date(2016, 10, 29), | ||
| 2017: date(2017, 10, 18), | ||
| 2018: date(2018, 11, 6), | ||
| 2019: date(2019, 10, 27), | ||
| 2020: date(2020, 11, 14), | ||
| 2021: date(2021, 11, 4), | ||
| 2022: date(2022, 10, 24), | ||
| 2023: date(2023, 11, 12), | ||
| 2024: date(2024, 10, 31), | ||
| 2025: date(2025, 10, 20), | ||
| 2026: date(2026, 11, 9) | ||
| } | ||
| return SG.shift_to_monday_if_weekend(dates.get(year)) | ||
|
|
||
| @staticmethod | ||
| def christmas_day(year): | ||
| """Return the date of Christmas Day for the given year.""" | ||
| return SG.shift_to_monday_if_weekend(date(year, 12, 25)) | ||
|
|
||
| # Legal sources: | ||
|
There was a problem hiding this comment. I apologize for being a bit imprecise with my statement "For all other countries the legal sources are added as a comment". What I meant was to use a docstring for this information, i.e. wrap in triple quotes and put it to the top. |
||
| # https://www.mom.gov.sg/employment-practices/public-holidays | ||
| # https://www.mom.gov.sg/employment-practices/public-holidays-entitlement-and-pay | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
|
There was a problem hiding this comment. Those are the wrong test files... 😅 You need to add those for Add your locale to holidata/holidays/init.py, sorted alphabetically into the list, rerun |
||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2011-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2012-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2013-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2014-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2015-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2016-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2017-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,14 +135,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2018-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,14 +143,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2019-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -151,14 +151,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2020-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,14 +143,6 @@ | |
| 'region': 'SL', | ||
| 'type': 'RV' | ||
| }, | ||
| { | ||
| 'date': '2021-08-15', | ||
| 'description': 'Mariä Himmelfahrt', | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the comment to
shift_to_monday_if_weekend, useSmartDayArrowfor all dates, i.e. do not use the datetime module at all. Also here, sorry for my imprecision when I just said "Use holidatas class SmartDayArrow..."See other country files on how to this is done, e.g. the region file for Ceuta where a date map similar to those used by you here is defined, or the country file for Great Britain.