Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when task config write is unsuccessfully #3620

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Throw error when task config write is unsuccessfully #3620

merged 2 commits into from
Sep 11, 2024

Conversation

gagankonana
Copy link
Contributor

Fixes #3611

  • Throw an error in setConfigVariable and unsetConfigVariable if write to config file is unsuccessfully

@gagankonana
Throw error when task config write is unsuccessfully
140fe93 
- Throw an error in setConfigVariable and unsetConfigVariable if write to config file is unsuccessfully
@gagankonana
remove iostream
bf73a66
djmitche
djmitche approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - thanks! I apologize for the delay reviewing this.

@djmitche djmitche merged commit c00c0e9 into GothenburgBitFactory:develop Sep 11, 2024
14 checks passed
@gagankonana
Copy link
Contributor Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gagankonana @djmitche