Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts/index and gothic sourcer article #135

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

muczc1wek
Copy link
Contributor

No description provided.

@kamilkrzyskow
Copy link
Collaborator

The language server is AFAIK tool agnostic, it's not bound to VS Code, but the extension using the language server is.
I also think if there are alternative tools to some aspects of Gothic Sourcer, then the article should have an opinionated comment about this, but I don't know about alternative 😆

@muczc1wek
Copy link
Contributor Author

muczc1wek commented Aug 8, 2024

The language server is AFAIK tool agnostic, it's not bound to VS Code, but the extension using the language server is.

So how should I put this? I know dls != vscode-daedalus, but for the regular user these things are the same

@kamilkrzyskow
Copy link
Collaborator

Perhaps they're seen as the same, but docs should strive for factuality. Of course there are some opinionated takes here or there, but there should be a good reason for those.

Here instead of "Also known as Daedalus Language Server", for example change it to "The VS Code extension acts as a proxy for the Daedalus Language Server to provide [list of features]" or "The VS Code extension provides [list of features] and uses Daedalus Language Server as the back-end for them." etc. maybe ChatGPT has something better.

docs/zengin/scripts/index.md Outdated Show resolved Hide resolved
docs/zengin/tools/gothic_sourcer.md Outdated Show resolved Hide resolved
docs/zengin/scripts/index.md Show resolved Hide resolved
@kamilkrzyskow
Copy link
Collaborator

LGTM, nice work on the preservation of the Gothic Sourcer in a separate repository 👍
You can squash merge when you want ✌️

@muczc1wek muczc1wek merged commit 9873e55 into Gothic-Modding-Community:dev Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants