-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance consern regardless zenkit::Polygon
#88
Comments
Hio, I added the |
zenkit::Polygon
zenkit::Polygon
Alternative might be to put |
This commit moves the allocation of many small vectors within `zenkit::Polygon` into a two larger vectors inside `zenkit::Mesh`, reducing the number of small allocation made. Doing this leads to a 25% performance boost (from 193ms to 144ms) on my laptop running Fedora 40 on an Intel Core i7-11800H.
@Try I've improved performance by ~25% on my machine. Please try it out the patch and let me know if this is to your liking :) |
Testing, time that Baseline:
With new changes:
Aside from mingw curiosities, when release build runs slower than debug, can say that it pretty substantial improvement. |
Out of curiosity: what compiler version are you using? It seems to produce very low performance code :/ |
|
I've noticed a performance regress on load-time after merging new version of phoenix(zenkit). While haven't done a real profiling yet, pausing application in debug almost always shows this callstack:
For now - just raising awareness.
And while at it, can you remind me why
zenkit::Polygon
is a thing?Asking about it, because currently I'm looking into more efficient mesh packing, and one of promising direction is instantiated list of 62 triangle strips - basically looking into what are the options are.
The text was updated successfully, but these errors were encountered: