🐛 fix(range): ajout de la possibilité de changer la value en JS [DS-3853] #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keryanS
commented
Oct 14, 2024
keryanS
commented
- Le composant est mis à jour graphiquement au changement de value des inputs en js.
lab9fr
changed the title
lab9fr
requested changes
Oct 23, 2024
| @@ -1,6 +1,7 @@ | |||
| import api from '../../api.js'; | |||
| import { RangeEmission } from './range-emission.js'; | |||
| import { RangeConstraints } from './range-constraints'; | |||
| import { completeAssign } from '../../../../core/script/api/utilities/property/complete-assign.js'; | |||
There was a problem hiding this comment.
il faut récupérer depuis api
Suggested change
| import { completeAssign } from '../../../../core/script/api/utilities/property/complete-assign.js'; |
| } | ||
| }; | ||
|
|
||
| return completeAssign(super.proxy, proxyAccessors); |
There was a problem hiding this comment.
Suggested change
| return completeAssign(super.proxy, proxyAccessors); | |
| return api.internals.property.completeAssign(super.proxy, proxyAccessors); |
lab9fr
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.