Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 refactor(download): séparation du download en carte et lien [DS-2972][DS-3244] #487

Merged
merged 16 commits into from
Jun 1, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Nov 30, 2022

Pour mutualiser les comportements de la carte et du lien au composant download, celui-ci doit devenir une variante de ces composants et non pas l'inverse.

Retrait du composant : téléchargement de fichier - Download -> déprécié
Ajout de la variante de carte : fr-card--download
Ajout de la variante de lien : fr-link--download

Le lien de téléchargement :

<div class="fr-download">
    <h3>
        <a href="[À MODIFIER - /example/img/image.jpg]" download class="fr-download__link">Télécharger le document lorem ipsum sit dolores amet
            <span class="fr-download__detail">
                JPG – 61,88 ko
            </span>
        </a>
    </h3>
</div>

DEVIENT :

<a class="fr-link fr-link--download" download href="[À MODIFIER - example/img/image.jpg]">
    Télécharger le document lorem ipsum sit dolores amet <span class="fr-link__detail">JPG – 61,88 ko</span>
</a>

et la carte de téléchargement :

<div class="fr-download fr-enlarge-link fr-download--card">
    <h3>
        <a href="[À MODIFIER - example/img/image.jpg]" download class="fr-download__link">Télécharger le document lorem ipsum sit dolores amet
            <span class="fr-download__detail">
                JPG – 61,88 ko
            </span>
        </a>
    </h3>
    <p class="fr-download__desc">Texte de description<</p>
</div>

DEVIENT :

<div class="fr-card fr-enlarge-link fr-card--download">
    <div class="fr-card__body">
        <div class="fr-card__content">
            <h3 class="fr-card__title">
                <a download href="[À MODIFIER - example/img/image.jpg]">
                    Télécharger le document lorem ipsum sit dolores amet
                </a>
            </h3>
            <p class="fr-card__desc">Texte de description</p>
            <div class="fr-card__end">
                <p class="fr-card__detail">JPG – 61,88 ko</p>
            </div>
        </div>
    </div>
</div>

BREAKING CHANGE : Remplacer le composant fr-download par la variante de link fr-link--download et remplacer le composant fr-download--card par une carte fr-card--download

@keryanS keryanS added the évolution Nouvelle fonctionnalité ou requête label Nov 30, 2022
@keryanS keryanS added this to the 1.9.0 milestone Nov 30, 2022
@keryanS keryanS requested a review from lab9fr November 30, 2022 16:44
@keryanS keryanS self-assigned this Nov 30, 2022
@keryanS keryanS marked this pull request as ready for review December 8, 2022 18:01
@lab9fr lab9fr changed the base branch from dev-1.9.0 to dev-1.10.0 February 28, 2023 11:18
@lab9fr lab9fr modified the milestones: 1.9.0, 1.10.0 Feb 28, 2023
Copy link
Contributor

@lab9fr lab9fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter dans analytics les exemples cards download et links download

@lab9fr lab9fr changed the title refactor(download): séparation du download en carte et lien [DS-2972] refactor(download): ✨ séparation du download en carte et lien [DS-2972] Mar 7, 2023
@lab9fr lab9fr changed the title refactor(download): ✨ séparation du download en carte et lien [DS-2972] refactor(download): séparation du download en carte et lien [DS-2972] Mar 7, 2023
@keryanS keryanS requested a review from lab9fr March 8, 2023 16:12
lab9fr
lab9fr previously approved these changes Mar 17, 2023
@lab9fr lab9fr added the Prêt label Mar 17, 2023
@lab9fr lab9fr changed the title refactor(download): séparation du download en carte et lien [DS-2972] 🚚 refactor(download): séparation du download en carte et lien [DS-2972] Mar 17, 2023
@lab9fr lab9fr removed the Prêt label Apr 18, 2023
@keryanS keryanS changed the base branch from dev-1.10.0 to main April 25, 2023 15:13
@keryanS keryanS requested a review from lab9fr April 25, 2023 15:13
@keryanS
Copy link
Contributor Author

keryanS commented Apr 25, 2023

Ajout de la version disabled

@keryanS keryanS changed the title 🚚 refactor(download): séparation du download en carte et lien [DS-2972] 🚚 refactor(download): séparation du download en carte et lien [DS-2972][DS-3244] Apr 26, 2023
@lab9fr lab9fr changed the base branch from main to dev-1.10.0 May 22, 2023 09:58
@lab9fr lab9fr added the Prêt label Jun 1, 2023
@lab9fr lab9fr merged commit 67c2aed into dev-1.10.0 Jun 1, 2023
@lab9fr lab9fr deleted the feat/download-card-link branch June 1, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maj 1.9.3 Prêt évolution Nouvelle fonctionnalité ou requête
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants