Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778, DS-3048] #502

Merged
merged 7 commits into from
Jun 19, 2023
Merged

♻️ refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778, DS-3048] #502

merged 7 commits into from
Jun 19, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Dec 21, 2022 •
edited
Loading

Uniformisation des champs à cocher toggle/radio/checkbox

toggle:

  • Ajout des variants toggle error/valid
  • Retrait du css sur input appearance:none
  • bordure en background svg
  • le toggle est maintenant placé dans un fieldset

radio:

  • Le contour devient bleu
  • retrait du fond blanc du radio bouton (transparence)
  • input déssiné en background image

radio-rich:

  • L'outline au focus englobe tout le radio-riche, plus l'input

checkbox:

  • Le contour devient bleu
  • correction changement d'état au mouse-down (:active), maintenant au mouse up

Form:

  • les hint-text des champs désactivés passent en couleur --text-disabled-grey

@keryanS keryanS added correctif Quelque chose ne fonctionne pas évolution Nouvelle fonctionnalité ou requête labels Dec 21, 2022
@keryanS keryanS added this to the 1.9.0 milestone Dec 21, 2022
@keryanS keryanS requested a review from lab9fr December 21, 2022 15:24
@keryanS keryanS self-assigned this Dec 21, 2022
@lab9fr lab9fr changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899] Dec 23, 2022
lab9fr
lab9fr requested changes Dec 23, 2022
View reviewed changes
src/component/radio/deprecated/style/_module.scss Outdated Show resolved Hide resolved
src/component/radio/deprecated/style/_module.scss Outdated Show resolved Hide resolved
src/component/checkbox/style/_scheme.scss Outdated Show resolved Hide resolved
src/component/radio/style/module/_rich.scss Show resolved Hide resolved
src/component/radio/style/module/_rich.scss Show resolved Hide resolved
src/component/radio/style/module/_sm.scss Outdated Show resolved Hide resolved
src/component/radio/style/module/_sm.scss Outdated Show resolved Hide resolved
@keryanS keryanS requested a review from lab9fr January 2, 2023 10:31
@lab9fr lab9fr modified the milestones: 1.9.0, 1.10.0 Feb 27, 2023
@lab9fr lab9fr changed the base branch from dev-1.9.0 to dev-1.10.0 February 27, 2023 17:43
@lab9fr lab9fr changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899] refactor(radio,checkbox,toggle): ✨ passage input en bleu et refactorisation [DS-2897,DS-2899] Mar 7, 2023
@lab9fr lab9fr changed the title refactor(radio,checkbox,toggle): ✨ passage input en bleu et refactorisation [DS-2897,DS-2899] refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899] Mar 7, 2023
@keryanS keryanS force-pushed the refactor/radio-checkox-toggle branch 2 times, most recently from 3dcc2d6 to b91bcb8 Compare March 9, 2023 17:35
@keryanS keryanS changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899] refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182] Mar 15, 2023
@keryanS keryanS changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182] refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778] Mar 15, 2023
@keryanS keryanS changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778] refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778, DS-3048] Mar 15, 2023
@lab9fr lab9fr changed the title refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778, DS-3048] ♻️ refactor(radio,checkbox,toggle): passage input en bleu et refactorisation [DS-2897,DS-2899, DS-2182, DS-2778, DS-3048] Mar 27, 2023
@lab9fr lab9fr force-pushed the refactor/radio-checkox-toggle branch from 8602f0b to 1a5d50e Compare May 22, 2023 10:31
@lab9fr lab9fr added Prêt and removed à faire labels Jun 15, 2023
@lab9fr lab9fr merged commit c13b930 into dev-1.10.0 Jun 19, 2023
@lab9fr lab9fr deleted the refactor/radio-checkox-toggle branch June 19, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

Assignees

@keryanS keryanS

Labels
correctif Quelque chose ne fonctionne pas maj 1.9.3 Prêt évolution Nouvelle fonctionnalité ou requête
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keryanS @lab9fr