Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315] #540

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

lab9fr
Copy link
Contributor

@lab9fr lab9fr commented Feb 28, 2023

Les radios riches doivent utiliser des pictogrammes et non des images.

Retrait des images
Ajout de pictograme

Le snippet :

<div class="fr-radio-group fr-radio-rich">
  <input value="1" type="radio" id="radio-rich-1" name="radio-rich">
  <label class="fr-label" for="radio-rich-1">
      Libellé bouton radio
  </label>
  <div class="fr-radio-rich__img">
      <img src="../../../example/img/placeholder.1x1.png" alt="[À MODIFIER - vide ou texte alternatif de l’image]" />
  </div>
</div>

DEVIENT :

<div class="fr-radio-group fr-radio-rich">
  <input value="1" type="radio" id="radio-rich-1" name="radio-rich">
  <label class="fr-label" for="radio-rich-1">
      Libellé bouton radio
  </label>
  <div class="fr-radio-rich__pictogram">
      <svg aria-hidden="true" class="fr-artwork" viewBox="0 0 80 80" width="80px" height="80px">
          <use class="fr-artwork-decorative" href="../../../dist/artwork/pictograms/buildings/city-hall.svg#artwork-decorative"></use>
          <use class="fr-artwork-minor" href="../../../dist/artwork/pictograms/buildings/city-hall.svg#artwork-minor"></use>
          <use class="fr-artwork-major" href="../../../dist/artwork/pictograms/buildings/city-hall.svg#artwork-major"></use>
      </svg>
  </div>
</div>

Remplacer buildings/city-hall par la catégorie et le nom du pictogramme désiré

BREAKING CHANGE : fr-radio-rich__img devient fr-radio-rich__pictogram

@lab9fr lab9fr added this to the 1.10.0 milestone Feb 28, 2023
@lab9fr lab9fr added the évolution Nouvelle fonctionnalité ou requête label Feb 28, 2023
@lab9fr lab9fr changed the title feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315] ✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315] Mar 27, 2023
@keryanS keryanS changed the title ✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315] ✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315][DS-1315] Apr 24, 2023
@lab9fr lab9fr added the Prêt label Jun 19, 2023
@lab9fr lab9fr requested a review from keryanS June 19, 2023 08:03
@lab9fr lab9fr changed the title ✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315][DS-1315] ✨ feat(radio): radio rich sans images & pictogram à la place d'img [DS-1315] Jun 19, 2023
@lab9fr lab9fr merged commit 5d0def0 into dev-1.10.0 Jun 19, 2023
@lab9fr lab9fr added Prêt and removed à vérifier labels Jun 19, 2023
@lab9fr lab9fr deleted the feat/radio-rich-no-image branch June 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maj 1.9.3 Prêt évolution Nouvelle fonctionnalité ou requête
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants